Failed to build Intermediate.cpp with SunStuido 12

RESOLVED FIXED in mozilla2.0b3

Status

()

defect
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: eagle.lu, Assigned: ginnchen+exoracle)

Tracking

Trunk
mozilla2.0b3
x86
OpenSolaris
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

6.29 KB, patch
vlad
: review+
Details | Diff | Splinter Review
Due to different STL implementation in SunStido 12, SunStudio 12 failed to compile Intermediate.cpp

see http://forums.sun.com/thread.jspa?threadID=5286643
Posted patch patch (obsolete) — Splinter Review
Assignee: nobody → brian.lu
Attachment #458298 - Flags: review?
Attachment #458298 - Flags: review? → review?(roc)
Attachment #458298 - Flags: review?(roc) → review?(pavlov)
Comment on attachment 458298 [details] [diff] [review]
patch

Tossing over to Vlad, since I don't know how he wants to handle patches to the ANGLE code.
Attachment #458298 - Flags: review?(pavlov) → review?(vladimir)
That is an entirely terrifying "different 'Standard' Template Library" implementation... 

But, submit this upstream to the angle project, and as far as landing it in mozilla create a .patch file, check that in along with the actual code change, and a note in the readme in gfx/angle.
We need some other patches in ANGLE code, I think we'd better combine the patches.
Also we'd better use a macro to detect libCStd is used.
Comment on attachment 458298 [details] [diff] [review]
patch

I don't think the patch is correct for the allocation size.
I could be wrong.
Attachment #458298 - Flags: review?(vladimir)
ok, I was wrong.
For libCStd, if _RWSTD_ALLOCATOR is not defined, the interface of allocator is different.
The return value is void*, size_type is number of bytes.
So reinterpret_cast<pointer> would not be necessary in this case.
Component: GFX: Color Management → Canvas: WebGL
QA Contact: color-management → canvas.webgl
I filed a bug in angle community. See http://code.google.com/p/angleproject/issues/detail?id=19
Posted patch patchSplinter Review
Assignee: brian.lu → ginn.chen
Attachment #458298 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #460483 - Flags: review?(vladimir)
Comment on attachment 460483 [details] [diff] [review]
patch

mostly NPOTB
except the change of gfx/angle/src/compiler/OutputGLSL.cpp
Attachment #460483 - Flags: approval2.0?
Attachment #460483 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/a302950274d9
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b3
angle-sunstudio.patch doesn't seem to have gotten checked in..
You need to log in before you can comment on or make changes to this bug.