Due to different STL implementation in SunStido 12, SunStudio 12 failed to compile Intermediate.cpp see http://forums.sun.com/thread.jspa?threadID=5286643
Assignee: nobody → brian.lu
Attachment #458298 - Flags: review?
Comment on attachment 458298 [details] [diff] [review] patch Tossing over to Vlad, since I don't know how he wants to handle patches to the ANGLE code.
Attachment #458298 - Flags: review?(pavlov) → review?(vladimir)
That is an entirely terrifying "different 'Standard' Template Library" implementation... But, submit this upstream to the angle project, and as far as landing it in mozilla create a .patch file, check that in along with the actual code change, and a note in the readme in gfx/angle.
We need some other patches in ANGLE code, I think we'd better combine the patches. Also we'd better use a macro to detect libCStd is used.
Comment on attachment 458298 [details] [diff] [review] patch I don't think the patch is correct for the allocation size. I could be wrong.
Attachment #458298 - Flags: review?(vladimir)
ok, I was wrong. For libCStd, if _RWSTD_ALLOCATOR is not defined, the interface of allocator is different. The return value is void*, size_type is number of bytes. So reinterpret_cast<pointer> would not be necessary in this case.
Component: GFX: Color Management → Canvas: WebGL
QA Contact: color-management → canvas.webgl
I filed a bug in angle community. See http://code.google.com/p/angleproject/issues/detail?id=19
Attachment #460483 - Flags: review?(vladimir) → review+
Comment on attachment 460483 [details] [diff] [review] patch mostly NPOTB except the change of gfx/angle/src/compiler/OutputGLSL.cpp
Attachment #460483 - Flags: approval2.0?
Attachment #460483 - Flags: approval2.0? → approval2.0+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b3
angle-sunstudio.patch doesn't seem to have gotten checked in..
You need to log in before you can comment on or make changes to this bug.