Closed Bug 579864 Opened 10 years ago Closed 10 years ago

Make SDK compiler detection more reliable

Categories

(mozilla.org :: MozillaBuild, task)

x86
Windows XP
task
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

Details

Attachments

(1 file)

The current script assumes that you've installed the compiler.
We should check the actual subkey that shows that it's installed.
Attached patch Possible patchSplinter Review
I noticed this because mozillabuild couldn't correctly find my compiler after I had upgraded to the Vista SDK 6.0A. (In the meantime I worked around the problem by creating a junction point back to the actual install location).

I should try installing the Windows 7 SDK compiler (VC9SP1EXPRESS) to see if I can write detection for it too.
Attachment #458308 - Flags: review?(ted.mielczarek)
Unlike the Vista SDK, the Windows 7 SDK puts the 32-bit compiler in the same place that VS2008 Express does, but instead of providing amd64\vcvarsamd64.bat (which I assume is provided by VS2008 Professional) it provides a choice of either vcvars64.bat (which is a true 64-bit compiler) or vcvarsx86_amd64.bat (which is a 32-bit compiler that produces 64-bit executables).
Attachment #458308 - Flags: review?(ted.mielczarek) → review+
Assignee: nobody → neil
Keywords: checkin-needed
Pushed with wrong bug number in comment:
http://hg.mozilla.org/mozilla-build/rev/fb0a68519dcc
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.