Closed
Bug 579912
Opened 14 years ago
Closed 13 years ago
Quirks in folderPane.css
Categories
(Thunderbird :: Theme, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 10.0
People
(Reporter: cursus.publicus, Unassigned)
Details
Attachments
(1 file)
625 bytes,
patch
|
bwinton
:
review+
clarkbw
:
ui-review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10_5_8; en-us) AppleWebKit/533.16 (KHTML, like Gecko) Version/5.0 Safari/533.16 Build Identifier: TB 3.1 The following was found in folderPane.css. It appears to contain an empty CSS statement and a separate spelling typo - 'grey' rather than the correct 'gray'. /* ::::: All Servers ::::: */ treechildren::-moz-tree-cell-text(folderNameCol, biffState-NewMail, isServer-true), treechildren::-moz-tree-cell-text(folderNameCol, newMessages-true), treechildren::-moz-tree-cell-text(folderNameCol, specialFolder-Inbox, newMessages-true) { font-weight: bold; color: blue; } treechildren::-moz-tree-cell(folderNameCol, newMessages-true), treechildren::-moz-tree-cell(folderNameCol, specialFolder-Inbox, newMessages-true) { } The above appears to have a few redundant lines and I suspect the following further down will fail to do anything as CSS only understands US English. .folderSummary-previewText { color: grey; } Reproducible: Always
Component: General → Folder and Message Lists
QA Contact: general → folders-message-lists
Version: unspecified → Trunk
Comment 1•14 years ago
|
||
Friday is indeed house cleaning day.
Reporter | ||
Comment 2•14 years ago
|
||
I cannot confirm that you have removed: treechildren::-moz-tree-cell(folderNameCol, newMessages-true), treechildren::-moz-tree-cell(folderNameCol, specialFolder-Inbox, newMessages-true) { }
OS: Mac OS X → All
Did you apply the patch to test this? Nothing has been checked in or even set up for review yet, how do you expect this to appear in the code if this is what you've looked up? ;-) Which prompts me to remind andreasn to flag this for review.
OS: All → Mac OS X
Hardware: PowerPC → All
Reporter | ||
Comment 4•14 years ago
|
||
Sorry Andreas - end of a long week - you have clearly removed it - orange in your attachment. rsx11m - This is not a code file which needs patching in order to test some outcome. It is a text file (folderPane.css) which required two simple edits which I now see have been done - I had looked at the attachment and made a foolish mistake.
Comment 5•14 years ago
|
||
Comment on attachment 459802 [details] [diff] [review] Patch on trunk Blake, Bryan: Do you want to review this? Should be pretty quick straightforward.
Attachment #459802 -
Flags: ui-review?(clarkbw)
Attachment #459802 -
Flags: review?(bwinton)
Comment 6•14 years ago
|
||
Comment on attachment 459802 [details] [diff] [review] Patch on trunk Since both 'grey' and 'gray' work (in gecko) it likely doesn't matter much. It might be good if we were to summarily remove all the 'grey' for 'gray' as we seem to swap back and forth. (in a follow up patch) http://mxr.mozilla.org/comm-central/search?find=%2Fmail%2Fthemes%2F&string=grey Thanks for catching the clean up! ui-r+
Attachment #459802 -
Flags: ui-review?(clarkbw) → ui-review+
Comment 7•14 years ago
|
||
Comment on attachment 459802 [details] [diff] [review] Patch on trunk What he said. ;)
Attachment #459802 -
Flags: review?(bwinton) → review+
Updated•13 years ago
|
Component: Folder and Message Lists → Toolbars and Tabs
Updated•13 years ago
|
Component: Toolbars and Tabs → Theme
QA Contact: folders-message-lists → theme
Confirming per the comments. This was reviewed and accepted by the Theme module owner. Has this been merged?
Comment 9•13 years ago
|
||
Checked in as http://hg.mozilla.org/comm-central/rev/4aedb030685a
Keywords: checkin-needed
Target Milestone: --- → Thunderbird 10.0
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 10•13 years ago
|
||
Thanks for correcting this.
You need to log in
before you can comment on or make changes to this bug.
Description
•