Closed
Bug 579975
Opened 14 years ago
Closed 14 years ago
logConsoleActivity() message filtering bug
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: msucan, Unassigned)
References
Details
Attachments
(1 file)
1.57 KB,
patch
|
mossop
:
review+
beltzner
:
approval2.0+
|
Details | Diff | Splinter Review |
The logConsoleActivity() filters messages using localized logLevel strings, which causes it to miss some messages. For example, it misses CSS warnings on google.com.
Reporter | ||
Comment 1•14 years ago
|
||
This patch fixes message filtering in the HUDService.logConsoleActivity() method. The patch should apply cleanly on mozilla-central.
Attachment #458399 -
Flags: review?(dtownsend)
Comment 2•14 years ago
|
||
Are there tests covering this functionality?
Comment 3•14 years ago
|
||
(In reply to comment #2) > Are there tests covering this functionality? Yes: http://mxr.mozilla.org/mozilla-central/source/toolkit/components/console/hudservice/tests/browser/browser_HUDServiceTestsAll.js?force=1#213
Updated•14 years ago
|
Attachment #458399 -
Flags: review?(dtownsend) → review+
Comment 4•14 years ago
|
||
Comment on attachment 458399 [details] [diff] [review] [checked-in] proposed fix http://hg.mozilla.org/mozilla-central/rev/a90e16166da9
Attachment #458399 -
Attachment description: proposed fix → [checked-in] proposed fix
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 5•14 years ago
|
||
Comment on attachment 458399 [details] [diff] [review] [checked-in] proposed fix a=beltzner, post hoc
Attachment #458399 -
Flags: approval2.0+
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•