579984 - --disable-ipc broken after e10s landing

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Zack Weinberg (:zwol)]

I'm not sure precisely when this broke, but --disable-ipc builds worked on Friday and don't now.  I assume this has something to do with the e10s landing.

make libs

make[1]: Entering directory `/home/zack/src/mozilla/obj-mozcentral/ipc/ipdl'

PGeolocationRequestParent.cpp

ccache g++ -o PGeolocationRequestParent.o -c -I../../dist/stl_wrappers -I../../dist/system_wrappers -include /home/zack/src/mozilla/moz-central/config/gcc_hidden.h -DMOZILLA_INTERNAL_API -DOSTYPE=\"Linux2.6\" -DOSARCH=Linux -I../../ipc/ipdl/_ipdlheaders -I/home/zack/src/mozilla/moz-central/ipc/ipdl -I. -I../../dist/include -I../../dist/include/nsprpub  -I/home/zack/src/mozilla/obj-mozcentral/dist/include/nspr -I/home/zack/src/mozilla/obj-mozcentral/dist/include/nss       -fPIC  -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-variadic-macros -Werror=return-type -pedantic -Wno-long-long -fno-strict-aliasing -fshort-wchar -pthread -pipe  -DDEBUG -D_DEBUG -DTRACING -g -Os -freorder-blocks -fomit-frame-pointer  -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gtk-unix-print-2.0     -DMOZILLA_CLIENT -include ../../mozilla-config.h -MD -MF .deps/PGeolocationRequestParent.pp PGeolocationRequestParent.cpp

In file included from ../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequestParent.h:9,

                 from PGeolocationRequestParent.cpp:7:

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:9:29: error: base/basictypes.h: No such file or directory

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:13:33: error: IPC/IPCMessageUtils.h: No such file or directory

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:18:39: error: mozilla/ipc/ProtocolUtils.h: No such file or directory

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:19:43: error: mozilla/net/NeckoMessageUtils.h: No such file or directory

In file included from PGeolocationRequestParent.cpp:7:

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequestParent.h:19:25: error: base/id_map.h: No such file or directory

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequestParent.h:20:36: error: mozilla/ipc/RPCChannel.h: No such file or directory

In file included from ../../ipc/ipdl/_ipdlheaders/mozilla/dom/PBrowserParent.h:9,

                 from PGeolocationRequestParent.cpp:9:

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PBrowser.h:19:30: error: mozilla/TabTypes.h: No such file or directory

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PBrowser.h:20:29: error: TabMessageUtils.h: No such file or directory

In file included from ../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:12,

                 from ../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequestParent.h:9,

                 from PGeolocationRequestParent.cpp:7:

../../ipc/ipdl/_ipdlheaders/IPCMessageStart.h:68: error: expected constructor, destructor, or type conversion before ‘(’ token

In file included from ../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequestParent.h:9,

                 from PGeolocationRequestParent.cpp:7:

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:47: error: ‘mozilla::ipc’ has not been declared

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:47: error: expected ‘,’ or ‘...’ before ‘trigger’

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h: In function ‘bool mozilla::dom::PGeolocationRequest::Transition(mozilla::dom::PGeolocationRequest::State, int)’:

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:53: error: ‘trigger’ was not declared in this scope

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:54: error: ‘next’ was not declared in this scope

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:65: error: ‘next’ was not declared in this scope

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h: At global scope:

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:70: error: ‘IPC’ has not been declared

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:70: error: expected ‘{’ before ‘Message’

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:71: error: invalid type in declaration before ‘{’ token

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:71: warning: extended initializer lists only available with -std=c++0x or -std=gnu++0x

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:72: error: expected primary-expression before ‘private’

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:72: error: expected ‘}’ before ‘private’

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:72: error: expected ‘,’ or ‘;’ before ‘private’

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:74: error: ‘mozilla::ipc’ has not been declared

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:74: error: expected initializer before ‘Shmem’

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:75: error: ‘IPC’ has not been declared

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:75: error: expected initializer before ‘URI’

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:77: error: expected unqualified-id before ‘public’

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:81: error: expected unqualified-id before ‘)’ token

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:88: error: expected unqualified-id before ‘&’ token

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:88: error: expected ‘)’ before ‘&’ token

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:88: error: expected initializer before ‘&’ token

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:99: warning: extra ‘;’

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:102: error: ‘IPC’ has not been declared

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:102: error: expected ‘{’ before ‘Message’

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:103: error: invalid type in declaration before ‘{’ token

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:103: warning: extended initializer lists only available with -std=c++0x or -std=gnu++0x

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:104: error: expected primary-expression before ‘private’

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:104: error: expected ‘}’ before ‘private’

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:104: error: expected ‘,’ or ‘;’ before ‘private’

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:106: error: ‘mozilla::ipc’ has not been declared

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:106: error: expected initializer before ‘Shmem’

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:107: error: ‘IPC’ has not been declared

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:107: error: expected initializer before ‘URI’

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:109: error: expected unqualified-id before ‘public’

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:113: error: expected unqualified-id before ‘)’ token

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:120: error: expected unqualified-id before ‘&’ token

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:120: error: expected ‘)’ before ‘&’ token

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:120: error: expected initializer before ‘&’ token

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:131: warning: extra ‘;’

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:134: error: ‘IPC’ has not been declared

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:134: error: expected ‘{’ before ‘Message’

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:135: error: invalid type in declaration before ‘{’ token

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:135: warning: extended initializer lists only available with -std=c++0x or -std=gnu++0x

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:136: error: expected primary-expression before ‘private’

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:136: error: expected ‘}’ before ‘private’

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:136: error: expected ‘,’ or ‘;’ before ‘private’

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:138: error: ‘mozilla::ipc’ has not been declared

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:138: error: expected initializer before ‘Shmem’

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:139: error: ‘IPC’ has not been declared

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:139: error: expected initializer before ‘URI’

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:141: error: expected unqualified-id before ‘public’

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:145: error: expected unqualified-id before ‘)’ token

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:152: error: expected unqualified-id before ‘&’ token

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:152: error: expected ‘)’ before ‘&’ token

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:152: error: expected initializer before ‘&’ token

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:163: warning: extra ‘;’

../../ipc/ipdl/_ipdlheaders/mozilla/dom/PGeolocationRequest.h:167: error: expected declaration before ‘}’ token

make[1]: *** [PGeolocationRequestParent.o] Error 1

make[1]: Leaving directory `/home/zack/src/mozilla/obj-mozcentral/ipc/ipdl'

make: *** [default] Error 2

2

zack@moxana:~/src/mozilla/obj-mozcentral/ipc/ipdl

$

Comment 1

[Zack Weinberg (:zwol)]

This is the error on a build from the top level:

ccache g++ -o dom_quickstubs.o -c -I../../../../dist/stl_wrappers -I../../../../dist/system_wrappers -include /home/zack/src/mozilla/moz-central/config/gcc_hidden.h -DMOZILLA_INTERNAL_API -DOSTYPE=\"Linux2.6\" -DOSARCH=Linux -DJSFILE -DJS_THREADSAFE -DEXPORT_XPC_API  -DJS_TRACER=1 -DFEATURE_NANOJIT=1 -DAVMPLUS_64BIT -DAVMPLUS_AMD64 -DAVMPLUS_LINUX -DAVMPLUS_UNIX  -I/home/zack/src/mozilla/moz-central/js/src/xpconnect/src/../wrappers -I/home/zack/src/mozilla/moz-central/js/src/xpconnect/src/../loader -I/home/zack/src/mozilla/moz-central/js/src -I/home/zack/src/mozilla/moz-central/js/src/nanojit -I/home/zack/src/mozilla/moz-central/caps/include -I/home/zack/src/mozilla/moz-central/content/base/src -I/home/zack/src/mozilla/moz-central/content/html/content/src -I/home/zack/src/mozilla/moz-central/content/html/document/src -I/home/zack/src/mozilla/moz-central/layout/style  -I/home/zack/src/mozilla/moz-central/js/src/xpconnect/src -I. -I../../../../dist/include -I../../../../dist/include/nsprpub  -I/home/zack/src/mozilla/obj-mozcentral/dist/include/nspr -I/home/zack/src/mozilla/obj-mozcentral/dist/include/nss       -fPIC  -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-variadic-macros -Werror=return-type -pedantic -Wno-long-long -fno-strict-aliasing -fshort-wchar -pthread -pipe  -DDEBUG -D_DEBUG -DTRACING -g -Os -freorder-blocks -fomit-frame-pointer    -DMOZILLA_CLIENT -include ../../../../mozilla-config.h -MD -MF .deps/dom_quickstubs.pp dom_quickstubs.cpp
In file included from /home/zack/src/mozilla/moz-central/content/html/content/src/nsGenericHTMLElement.h:47,
                 from dom_quickstubs.cpp:158:
/home/zack/src/mozilla/moz-central/content/base/src/nsFrameLoader.h:81: error: ‘PBrowserParent’ in namespace ‘mozilla::dom’ does not name a type
/home/zack/src/mozilla/moz-central/content/base/src/nsFrameLoader.h:82: error: ‘TabParent’ in namespace ‘mozilla::dom’ does not name a type
make[5]: *** [dom_quickstubs.o] Error 1
make[5]: Leaving directory `/home/zack/src/mozilla/obj-mozcentral/js/src/xpconnect/src'
make[4]: *** [libs] Error 2
make[4]: Leaving directory `/home/zack/src/mozilla/obj-mozcentral/js/src/xpconnect'
make[3]: *** [libs_tier_platform] Error 2
make[3]: Leaving directory `/home/zack/src/mozilla/obj-mozcentral'
make[2]: *** [tier_platform] Error 2
make[2]: Leaving directory `/home/zack/src/mozilla/obj-mozcentral'
make[1]: *** [default] Error 2
make[1]: Leaving directory `/home/zack/src/mozilla/obj-mozcentral'
make: *** [build] Error 2

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

I suppose these lines in content/base/src/nsFrameLoader.h

+  typedef mozilla::dom::PBrowserParent PBrowserParent;
+  typedef mozilla::dom::TabParent TabParent;

needed ifdefs as well.

Comment 3

[Mark Banner (:standard8)]

I checked in a bustage fix after clearing it with cjones over irc:

http://hg.mozilla.org/mozilla-central/rev/97f9e69d3519

I think this works, I think my build is now seeing other bustages :-(

We'll call this fixed for now anyway.