Closed Bug 580068 Opened 15 years ago Closed 11 years ago

nsXREDirProvider::DoShutdown() does a GC on shutdown and leaks the context

Categories

(Toolkit :: Startup and Profile System, defect)

Product:
Toolkit
Component:
Startup and Profile System
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 833143

People

(Reporter: gal, Unassigned)

Details

Random components shouldn't GC as part of shutdown. No wonder shutdown is so slow. Also, I think the context is leaked here. http://mxr.mozilla.org/mozilla-central/source/toolkit/xre/nsXREDirProvider.cpp#799
I'm not sure what "leaking" a context means. The comment above explains why we're doing the extra JS_GC there, which is a behavior which has existed since before my time. I'm happy to remove it, but I'm worried it may change behavior of things which expect to be released at some particular time.
Component: XULRunner → Startup and Profile System
OS: Mac OS X → All
QA Contact: xulrunner → startup
Hardware: x86 → All
Yeah, no JSContext was leaked in making this (old, short-subject) movie. But it is sketchy that someone patched in a JS_GC call. Hope my name was not involved! /be
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.