580211 - 'Your tabs from last time' section doesn't display tabs from last session after a restart

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[ahoza]

User-Agent:       Mozilla/5.0 (Windows; Windows NT 6.1; en-US; rv:2.0b2pre) Gecko/20100718 Minefield/4.0b2pre
Build Identifier: Mozilla/5.0 (Android; Linux armv7l;en-US;rv:2.0b2pre) Gecko/20100717 Namoroka / 4.0b2pre Fennec/2.0a1pre

"No tabs from last time" is always displayed in "Your tabs from last time" section, about:home page.

Reproducible: Always

Steps to Reproduce:
1.Open Fennec
2.Go to Options|Preferences and make sure Start page is "Fennec Start"
3.Open yahoo.com and cnn.com in separate tabs.
4. Go to Options|Add-ons and install an add-on
5. When asked, restart the browser. 
Actual Results:  
"No tabs from last time" is displayed in "Your tabs from last time" section

Expected Results:  
yahoo.com and cnn.com are displayed in "Your tabs from last time" section, after restart.

Comment 1

[ahoza]

Device: HTC Desire A8181

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

I was able tor eproduce this issue on desktop as well. It seems that we could shutdown fast enough that we'd miss saving the session.

This patch forcibly saves the session on shutdown. It also cleans up some code.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/87c657be0cd4

Comment 4

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b2pre) Gecko/2010723 Namoroka/4.0b2pre Fennec/2.0a1pre

and

Mozilla/5.0 (Android; U; Linux armv71; en-US; rv:2.0b2pre) Gecko/20100723 Namoroka/4.0b2pre Fennec/2.0a1pre