Closed Bug 580217 Opened 15 years ago Closed 15 years ago

> starting a bug summary causes comment quote coloring (leading greater than character makes it purple)

Categories

(Bugzilla :: Creating/Changing Bugs, defect)

3.6.1
defect
Not set
minor

Tracking

()

RESOLVED FIXED
Bugzilla 3.6

People

(Reporter: davemgarrett, Assigned: guy.pyrzak)

References

Details

(Keywords: regression)

Attachments

(1 file, 2 obsolete files)

See this bug's summary. With a leading greater than character (">") the bug summary/title has the purple coloring for replies in comments.
Summary: > starting a bug summary causes reply coloring (leading greater than character) → > starting a bug summary causes comment quote coloring (leading greater than character makes it purple)
I can reproduce upstream.
Severity: normal → minor
Version: unspecified → 3.6.1
Should be pretty easy to fix--we just don't do the quote coloring if there isn't a $comment object passed to quoteUrls.
Attached patch v1 (obsolete) — Splinter Review
Assignee: create-and-change → guy.pyrzak
Attachment #467572 - Flags: review?(mkanat)
Attachment #467572 - Flags: review?(LpSolit)
Depends on: 505640
Keywords: regression
Target Milestone: --- → Bugzilla 3.6
Attached patch V2 (obsolete) — Splinter Review
Attachment #467572 - Attachment is obsolete: true
Attachment #467587 - Flags: review?(LpSolit)
Attachment #467572 - Flags: review?(mkanat)
Attachment #467572 - Flags: review?(LpSolit)
Comment on attachment 467587 [details] [diff] [review] V2 Why not just use the bz_comment_text class instead of #comments?
Attached patch v3Splinter Review
good call, that's a better class to use
Attachment #467587 - Attachment is obsolete: true
Attachment #468364 - Flags: review?(mkanat)
Attachment #468364 - Flags: review?(LpSolit)
Attachment #467587 - Flags: review?(LpSolit)
Attachment #468364 - Flags: review?(mkanat)
Attachment #468364 - Flags: review?(LpSolit)
Attachment #468364 - Flags: review+
Flags: approval4.0+
Flags: approval3.6+
Flags: approval+
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/ modified skins/standard/global.css Committed revision 7454. Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/4.0/ modified skins/standard/global.css Committed revision 7390. Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/3.6/ modified skins/standard/global.css Committed revision 7166.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: