580227 - In-tree testpilot extension doesn't register its component

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Benjamin Smedberg]

The in-tree testpilot extension hasn't been fixed up for the new XPCOM registration changes and doesn't register components/TestPilot.js

I'm not sure where this code lives originally or whether its already fixed upstream. Who owns the testpilot impl?

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Jono does, and he's gone for a month, I think? cc'ing dtownsend. I take it this means that Testpilot just done doesn't work with the new beta? How is it working with nightlies?

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Ah, it doesn't actually work, it's just I get the XUL around it and no visible errors.

Bully.

Comment 3

[Benjamin Smedberg]

Attachment: Testpilot registration, rev. 1

I wrote this patch blind.

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 458654 [details] [diff] [review]
Testpilot registration, rev. 1

I want to keep the in-tree version in sync with the Test Pilot extension as much as possible so can you do the extra bit to make this component work in both 1.9.2 and 2.0? Could you also bump the version in the install.rdf to 1.0 and the maxVersion to 4.0b2. I meant to do this with the couple of landings yesterday but forgot about it.

Once we've fixed this on trunk I'll push the same changes upstream.

Comment 5

[Benjamin Smedberg]

Attachment: Backwards-compatible change against the labs/testpilot repo, rev. 1

Comment 6

[Dave Townsend [:mossop]]

Comment on attachment 458704 [details] [diff] [review]
Backwards-compatible change against the labs/testpilot repo, rev. 1

r=me and landed on trunk with the version bumps. We need to clarify the upstream situation as there are fixes there that Jono didn't say he wanted on trunk and fixes on trunk that haven't yet made it there.

http://hg.mozilla.org/mozilla-central/rev/1a63c61cdc6a

Comment 7

[Benjamin Smedberg]

http://hg.mozilla.org/labs/testpilot/rev/1e524d9746c8