Closed Bug 580293 Opened 10 years ago Closed 10 years ago

Next/Previous buttons are enabled when search field is empty

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: aakashd, Assigned: vingtetun)

Details

Attachments

(1 file)

Build id:
Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b2pre) Gecko/2010720 Namoroka/4.0b2pre Fennec/2.0a1pre

and

Mozilla/5.0 (Android; U; Linux armv71; en-US; rv:2.0b2pre) Gecko/20100720 Namoroka/4.0b2pre Fennec/2.0a1pre


Steps to Reproduce:
1. Go to www.google.com/news
2. Open the site panel
3. Click on "Find"

Actual Results:
The next/previous buttons are enabled and clickable even though they can't perform an action (no search term).

Expected Results:
The next/previous buttons should be disabled until a search term is entered into the find field.
Attached patch PatchSplinter Review
This patch disabled the buttons when the textbox value is "".
Assignee: nobody → 21
Attachment #458850 - Flags: review?(mark.finkle)
Comment on attachment 458850 [details] [diff] [review]
Patch

We need to think about how we can tell if we are at the beginning or end of the document too. We'll need to disable the next or previous button in those cases.
Attachment #458850 - Flags: review?(mark.finkle) → review+
http://hg.mozilla.org/mobile-browser/rev/c562f5dc7354
 
> We need to think about how we can tell if we are at the beginning or end of the
> document too. We'll need to disable the next or previous button in those cases.

Yes. Actually I'm not sure of how to do it, I've adopt the behavior of desktop Firefox but we can differ if needed (which can make sense, I don't think someone has look at that since...)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110920
Firefox/9.0a1 Fennec/9.0a1
Device: HTC Desire
OS: Android 2.2
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.