580411 - AutoCompartment and JS_Enter/LeaveCrossCompartmentCall should support the trivial case of not changing compartments

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

Currently, in AutoCompartment's constructor, we have

  JS_ASSERT(origin != destination);

True for wrappers, but there are cases where it's inconvenient and pointless for the caller to ensure that this is true. Instead we should just allow it.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: v1

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 458840 [details] [diff] [review]
v1

> bool
> AutoCompartment::enter()
> {
>     JS_ASSERT(!entered());

Can we check destination against context->compartment and do nothing if they're the same?

>         context->compartment = origin;
>+		return false;

Hard tabs must die!

Comment 3

[Jason Orendorff [:jorendorff]]

Attachment: v2

Comment 4

[Jason Orendorff [:jorendorff]]

http://hg.mozilla.org/tracemonkey/rev/4fda7181fac5

Comment 5

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/4fda7181fac5