Download source "unknown" is listed as "null" in /addon/2257/statistics/sources-month-20100101-20100507.csv

VERIFIED FIXED in 5.12.3

Status

addons.mozilla.org Graveyard
Statistics
P5
normal
VERIFIED FIXED
8 years ago
2 years ago

People

(Reporter: krupa, Assigned: potch)

Tracking

Details

(Whiteboard: [z], URL)

Attachments

(3 attachments)

(Reporter)

Description

8 years ago
steps to reproduce:

1. Go to https://next.addons.mozilla.org/z/en-US/firefox/addon/2257/statistics/sources-month-20100101-20100507.csv
2. Notice the download sources listed

observed behavior:
One of the listed download source is "null". This should probably be changed to "unknown"

(Unknown is a download source available in remora)
Target Milestone: --- → 5.11.6
Target Milestone: 5.11.6 → 5.11.7
I'll look at what this should be doing in 5.11.8
Assignee: thepotch → clouserw
Target Milestone: 5.11.7 → 5.11.8
Daniel:  I'm looking at the data for this add-on in the database and I see:

a:15:{s:6:"search";i:739;s:18:"similarcollections";i:2;s:10:"developers";i:3;s:11:"recommended";i:1720;s:9:"creatured";i:128;s:13:"oftenusedwith";i:1;s:3:"api";i:9995;s:10:"collection";i:123;s:4:"null";i:364;s:14:"homepagebrowse";i:669;s:11:"addondetail";i:2344;s:8:"category";i:379;s:13:"homepagepromo";i:83;s:10:"sharingapi";i:1;s:11:"userprofile";i:8;}


is "null" the total of unknown sources or is it something else?
Those are requests which have no src= parameter at all.  If you'd like us to put something else in rather than null it can be done.  Don't believe it was ever part of the spec so we just left it with the default behavior.
Great, thanks.  This bug as it stands is a WONTFIX then.  I'm assigning this to potch though so we can make the front end say "Unknown"
Assignee: clouserw → chowse
Assignee: chowse → thepotch
Priority: -- → P5
Target Milestone: 5.11.8 → 5.12
Target Milestone: 5.12 → 5.12.1
(Assignee)

Updated

7 years ago
Target Milestone: 5.12.1 → 5.12.2
(Assignee)

Updated

7 years ago
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Reporter)

Comment 5

7 years ago
This is not fixed under "Download sources by Date". See attached screenshot.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Comment 6

7 years ago
Created attachment 488107 [details]
screenshot

Updated

7 years ago
Target Milestone: 5.12.2 → 5.12.3
(Assignee)

Comment 7

7 years ago
http://github.com/jbalogh/zamboni/commit/3fdd571
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
(Reporter)

Comment 8

7 years ago
There is still a mention of "null" at https://addons.allizom.org/z/en-US/firefox/addon/2257/statistics/sources-day-20100813-20101111.csv mentioned in comment 0.

reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Comment 9

7 years ago
Created attachment 489996 [details]
screenshot-11/11
(Assignee)

Comment 10

7 years ago
Despite the title, this bug doesn't cover fixing the CSVs, just the frontend.
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
I think the CSVs and "null" are fine
(Reporter)

Comment 13

7 years ago
Created attachment 490594 [details]
post-fix screenshot
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.