580421 - Invalid Locale Codes Should Result in Error Page

Status: VERIFIED FIXED

(Websites :: plugins.mozilla.org, defect)

Description

[Michael Coates [:mcoates] (acct no longer active)]

Issue

The plugin URL contains a locale code such as 'en-us' as seen in the following example:
https://plugins.mozilla.org/en-us/plugins/detail/gnome-totem

An attacker can modify this value to arbitrary text and the plugins web application will still render the requested page as normal. An attacker could use a convincing message in order to entice users to install particular software.

Example:
https://plugins.mozilla.org/ApprovedByMozilla/plugins/detail/gnome-totem



Recommended Remediation

Check if the locale code is a valid value and redirect to an error page if any other values are received.

Comment 1

[Les Orchard [:lorchard]]

r71440 should address this on staging shortly

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED:

https://plugins.stage.mozilla.com/0/plugins/detail/gnome-totem redirects to:

https://plugins.stage.mozilla.com/en-us