58043 - `Always use my fonts' uses my fonts in sidebar panel chrome

Status: VERIFIED DUPLICATE of bug 58048

(Core :: Layout, defect, P3)

Description

[Matthew T (active 1999-2002)]

Build: 2000102420, Mac OS 9.0

To reproduce:
* Open the Search sidebar panel.
* Open the prefs dialog, and select `Always use my fonts' in the Fonts panel.
* Click OK.

What happens:
* The `Search' and `Bookmark Search Results' button, the `Search Results'
  treehead, and search results (and bookmarks in the Bookmarks panel) are
  redrawn to use your chosen text/HTML fonts.

What should happen:
* Your chosen text/HTML fonts should have no effect on the fonts used in the
  chrome whatsoever.

Comment 1

[Marc Attinasi]

The problem is that the sidebar is not really chrome, which is to say that the 
docShellType is not nsIDocShellTreeItem::typeChrome. This problem was known when 
we checked in the pref stylesheet changes. We'll need to see about getting the 
sidebar panels to mark themselves as chrome...

Comment 2

[Ben Bucksch (:BenB)]

Should they mark *themselves* as chrome? Because a normal web panel could do the
same, then, not?

Comment 3

[Marc Attinasi]

I'm not sure exactly what is going on, but it appears that the decision is made
in nsHTMLFrameInnerFrame::CreateDocShell based upon the type attribute of the
parentContent, whatever that is
(http://lxr.mozilla.org/seamonkey/source/layout/html/document/src/nsFrameFrame.cpp#779
). My guess is that some of the sidebar panels are using HTML content and some
are not, but that is just a guess. I'll have to dig in and see what the root
cause is so I can determine who needs to modify what. I'm almost positive that
there is nothing I can do with respect to my changes, since I test the
docShellType for chrome, and that is all I have to go on really.

FYI: the colors are applied too, if 'always use my colors' is checked.

Comment 4

[Marc Attinasi]

Note to self: need to find the sidebar owner and find out how we can flag 
sidebar content as 'chrome' even if it is HTML content...

Comment 5

[Matthew T (active 1999-2002)]

A simpler way to do it would be to use system fonts and colors by default for 
widgets in HTML content, which you should be doing anyway.

Comment 6

[Marc Attinasi]

That would solve much of the problem, however if you look at the 'search' panel,
it has a body background that is taking on the default color as well, and that
should not be happening. The part about the control colors (and fonts) is being
handled by bug 58048.

Comment 7

[Marc Attinasi]

marking as a dup of 58403 since that is the primary complaint.

*** This bug has been marked as a duplicate of 58403 ***

Comment 8

[Ben Bucksch (:BenB)]

I think, that was the wrong bug. REOPENing.

Comment 9

[Marc Attinasi]

Thanks Ben, the correct bug is bug 58048

*** This bug has been marked as a duplicate of 58048 ***

Comment 10

[James Green]

Verified dup.