Last Comment Bug 580455 - Text of a selected message or folder isn't centered/aligned with its highlight bar
: Text of a selected message or folder isn't centered/aligned with its highligh...
Status: RESOLVED FIXED
: polish, regression, ux-consistency
Product: Thunderbird
Classification: Client Software
Component: Theme (show other bugs)
: unspecified
: x86 Windows XP
: -- trivial (vote)
: Thunderbird 17.0
Assigned To: Richard Marti (:Paenglab)
:
Mentors:
Depends on: 820306
Blocks:
  Show dependency treegraph
 
Reported: 2010-07-20 17:12 PDT by Karel Koubek
Modified: 2012-12-11 12:11 PST (History)
5 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Misaligned text highlight (29.27 KB, image/png)
2010-07-20 17:13 PDT, Karel Koubek
no flags Details
patch (964 bytes, patch)
2012-08-14 06:21 PDT, Richard Marti (:Paenglab)
bugs: review+
bugs: ui‑review+
Details | Diff | Splinter Review

Description Karel Koubek 2010-07-20 17:12:04 PDT
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.6) Gecko/20100625 Firefox/3.6.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.7) Gecko/20100713 Thunderbird/3.1.1

The text of a selected message or folder isn't centered with its highlight bar, should be positioned about 1-2px higher, see attached screenshots. The icons seem to be positioned fine.

This slight visual glitch is a regression from Thunderbird 2.x, where the text is centered fine.

Reproducible: Always
Comment 1 Karel Koubek 2010-07-20 17:13:13 PDT
Created attachment 458845 [details]
Misaligned text highlight
Comment 2 Richard Marti (:Paenglab) 2012-08-14 06:21:36 PDT
Created attachment 651740 [details] [diff] [review]
patch

Giving -moz-tree-cell-text a padding-bottom of 2px centers the text. On Win7 under default themes removing it again lets the text still centered on Aero and Basic.
Comment 3 Andreas Nilsson (:andreasn) 2012-08-21 06:39:08 PDT
Comment on attachment 651740 [details] [diff] [review]
patch

looks good ui-wise
Comment 4 Andreas Nilsson (:andreasn) 2012-08-21 06:45:20 PDT
Comment on attachment 651740 [details] [diff] [review]
patch

I was a bit torn over padding-bottom: auto; in messenger-aero.css, but since it's supposed to override the one in messenger.css, I think it makes sense.
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-08-21 16:47:22 PDT
https://hg.mozilla.org/comm-central/rev/ce6fbd594079
Comment 6 Greg K. 2012-12-11 02:37:46 PST
I filed Bug 820306 because of the warning generated by padding-bottom:auto. Isn't that an invalid value for a <padding-width>-type?

Note You need to log in before you can comment on or make changes to this bug.