580510 - [fr] Update Amazon, eBay and Wikipedia logos for search plugins

Status: VERIFIED FIXED

(Mozilla Localizations :: fr / French, defect)

Description

[Pascal Chevrel:pascalc (PTO until April 26)]

Attachment: screenshot

The favicon for amazon.fr for Firefox 4 beta 2 has white artifacts around the A, the white pixels should probably be transparent, maybe we are using a gif image with no real transparency instead of png. This is very visible on a dark theme like Ubuntu's default, I don't know for other platforms but I believe Windows Seven also uses a dark theme and might be affected as well.

See screenshot.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Is this a regression against beta 1 or even 3.6.7?

Comment 2

[Pascal Chevrel:pascalc (PTO until April 26)]

This is not a regression, 3.6.7 also has a bad icon, I hadn't noticed before because the Linux distro version that I used does not ship with the amazon.fr search plugin but the en-US one which has a different favicon 
(beta 1 was en-US only btw)

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks Pascal. Kev, is that an already known problem?

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Sort of a dupe of bug 580510, I guess. New icons were provided in bug 421613, but they weren't updated in localized plugins.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #4)
> Sort of a dupe of bug 580510, I guess.

Er, bug 421745, I mean.

Comment 6

[Kev Needham [:kev]]

what gavin said. what's in the en-US defaults is the icon Amazon has auth'd for distribution. if it's not changed in the locales, it should be on all current branches as soon as possible.

Comment 7

[Cédric Corazza]

Pascal, can we close this bug?

Comment 8

[Scoobidiver (away)]

The Amazon logo in the French build is not the same as the one in the en-US build.

Comment 9

[Théo Chevalier]

As well as Wikipedia & Ebay.

Is there any reason that would prevent me from taking those in en-US files to update fr?

Comment 10

[:Gavin Sharp [email: [e-mail]]]

I don't think so - I'd recommend you do exactly that!

Comment 11

[Scoobidiver (away)]

(In reply to Théo Chevalier [:tchevalier] from comment #9)
> Wikipedia
French (map of the world) and en (W) Wikipedia search plugin logos were different at the beginning (bug 380785). I don't know why.

> Ebay.
It's a consequence of bug 812682.

Comment 12

[Théo Chevalier]

Thanks! Amazon, eBay and Wikipedia icons updated across channels

http://hg.mozilla.org/l10n-central/fr/rev/4dffb010527a
http://hg.mozilla.org/releases/l10n/mozilla-aurora/fr/rev/bb98158842ac
http://hg.mozilla.org/releases/l10n/mozilla-beta/fr/rev/bfd24e0bc0ef

Comment 13

[Théo Chevalier]

Guess we can close this bug

Comment 14

[Axel Hecht [:Pike]]

Please always request review before landing changes to search plugins and region.properties, they're just too easy to get wrong.

Milos, can you do post-mortem reviews here?

Comment 15

[Milos Dinic [:Milos]]

Axel,

yep, as per https://bugzilla.mozilla.org/show_bug.cgi?id=421613 , this is postmortem r+.