580564 - Alt + Space bar, "Restore" wont restore when Firefox is in full screen mode.

Status: REOPENED

(Core :: Widget: Win32, defect)

Description

[Biju]

Mozilla/5.0 (Windows; Windows NT 6.0; en-US; rv:2.0b2pre) 
Gecko/20100714 Minefield/4.0b2pre

When in full screen mode,  pressing Alt + Space bar then selecting  "Restore" wont make Firefox come out of full screen mode.

Steps:-
1. Start Firefox
2. Go fullscreen mode
3. Press Alt + Space bar 
4. Select "Restore" from the control box menu.

Result:-
Nothing happence

Expected:-
Firefox should end fullscreen mode

Comment 1

[Jo Hermans]

This seems to be new - it doesn't occur in Firefox 3.6.7

Comment 2

[(mostly gone) XtC4UaLL [:xtc4uall]]

See also Bug 580599.

Comment 4

[Jim Mathies [:jimm]]

Attachment: fix

Sorry Neil, two in a row. This one is pretty simple though. It's built and tested on top of the patch in bug 632748.

Comment 5

[[e-mail]]

Comment on attachment 535445 [details] [diff] [review]
fix

While I can see the point of the nsWindow changes, are the nsWebShellWindow changes relevant, and if so, how?

Comment 6

[Jim Mathies [:jimm]]

(In reply to comment #5)
> Comment on attachment 535445 [details] [diff] [review] [review]
> fix
> 
> While I can see the point of the nsWindow changes, are the nsWebShellWindow
> changes relevant, and if so, how?

We currently notify the global window from widget when we go into full screen, but we don't notify when we exit. Normally we exit via the DOM but in this case, widget is initiating the change, so we have let the DOM know.

nsGlobalWindow fires a 'fullscreen' event in response to this:
http://mxr.mozilla.org/mozilla-central/source/dom/base/nsGlobalWindow.cpp#4330

Comment 7

[[e-mail]]

Comment on attachment 535445 [details] [diff] [review]
fix

Aha, makes sense now, thanks.

Comment 8

[Jim Mathies [:jimm]]

http://hg.mozilla.org/mozilla-central/rev/dc1077c09540

Comment 9

[Jim Mathies [:jimm]]

backed out due to regression bug 663586:
http://hg.mozilla.org/mozilla-central/rev/854df0c7239e

Comment 10

[Karl Tomlinson (:karlt)]

Was https://hg.mozilla.org/mozilla-central/rev/1b0294c7b952
enough to fix this?