580601 - GLContextEGL::CreateEGLPixmapOffscreenContext is broken

Status: RESOLVED DUPLICATE of bug 659832

(Core :: Graphics, defect)

Description

[Oleg Romashin (:romaxa)]

On latest trunk, 
http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/GLContextProviderEGL.cpp#1059

GLContextEGL::CreateEGLPixmapOffscreenContext   call  GetGlobalContextEGL
http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/GLContextProviderEGL.cpp#1132

which is calling CreateOffScreen
http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/GLContextProviderEGL.cpp#1284

and that is calling GLContextEGL::CreateEGLPixmapOffscreenContext
http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/GLContextProviderEGL.cpp#1176


This looks very strange and broken

Comment 1

[Oleg Romashin (:romaxa)]

ah, and full  call sequence is:
WEBGL->CreateOffScreen->CreateEGLPixmapOffscreenContext->GetGlobalContextEGL->CreateOffScreen->CreateEGLPixmapOffscreenContext->GetGlobalContextEGL->null->null->null

Comment 2

[Oleg Romashin (:romaxa)]

I was testing on Qt port, and Qt port works fine on Desktop with GLX backend

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Ah, CreateEGLPixmapOffscreenContext is just missing a boolean arg to specify that sharing is not required, which GetGlobalContextEGL should specify.

Comment 4

[Ali Juma [:ajuma]]

The fix identified in Comment 3 was included in the patch for Bug 659832.