580647 - Beta page doesn't validate

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

http://www-trunk.stage.mozilla.com/en-US/firefox/beta/ doesn't validate:

http://validator.w3.org/check?uri=http%3A%2F%2Fwww-trunk.stage.mozilla.com%2Fen-US%2Ffirefox%2Fbeta%2F&charset=%28detect+automatically%29&doctype=Inline&group=0

Comment 1

[Stephen DesRoches]

This is caused by the php function that does browser detection. It's not necessarily related to specifically this page.

The validation change will need to be updated in:

<?=buildPlatformImage('/img/firefox/beta/4/feedback-button.png', 'Feedback button screenshot')?>

Comment 2

[Stephen DesRoches]

Turns out I was using the php function wrong.

Validation problems fixed in r71076

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #2)
> Turns out I was using the php function wrong.
> 
> Validation problems fixed in r71076

Thanks; please mark bugs fixed when you fix them.  I noticed you didn't have the appropriate Bugzilla permissions to do so, so I've granted you edit_bugs and canconfirm; enjoy :-)

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Thanks, Stephen.

Verified FIXED.

Comment 5

[Stephen DesRoches]

Sure, I'm not sure what the practice is on marking bugs as fixed. Do I do that before QA verifies it?

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #5)
> Sure, I'm not sure what the practice is on marking bugs as fixed. Do I do that
> before QA verifies it?

Yes; if development is done, please mark it fixed.  The largest part of our workflow is looking at Resolved FIXED bugs, and it's too easy to miss bugs needing QA's attention if they're still in the open state.  Thanks!