580690 - Building calendar on OS X 10.6.4 fails with linking error nsEditProperty::mozEditorBogusNode

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Nathaniel Madura]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en; rv:1.9.0.15) Gecko/2009102617 Camino/2.0 (like Firefox/3.0.15)
Build Identifier: latest source

I have setup my environment per instructions at <https://developer.mozilla.org/en/Simple_Sunbird_build>

$ uname -a
Darwin xxxxx.umtri.umich.edu 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386

$ xcodebuild -version
Xcode 3.2.3
Component versions: DevToolsCore-1691.0; DevToolsSupport-1591.0
BuildVersion: 10M2262

MacPorts version 1.9.1

$ cat .mozconfig
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/objdir-sb-debug
mk_add_options MOZ_MAKE_FLAGS="-s -j4"
ac_add_options --enable-application=calendar
ac_add_options --enable-debug
ac_add_options --disable-optimize
ac_add_options --enable-calendar
ac_add_options --with-macos-sdk=/Developer/SDKs/MacOSX10.6.sdk
ac_add_options --disable-tests

When I execute 
make -f client.mk
*after waiting a long while, the following error occurs* 

nsContentDLF.cpp
nsLayoutStatics.cpp
In file included from /Users/Shared/comm-central/mozilla/content/xul/content/src/nsXULElement.h:62,
                 from /Users/Shared/comm-central/mozilla/layout/build/nsLayoutStatics.cpp:99:
../../dist/include/nsIDOMXULSelectCntrlEl.h:33: warning: ‘virtual nsresult nsIDOMXULSelectControlElement::GetSelectedItem(nsIDOMXULSelectControlItemElement**)’ was hidden
../../dist/include/nsIDOMXULMultSelectCntrlEl.h:73: warning:   by ‘virtual nsresult nsIDOMXULMultiSelectControlElement::GetSelectedItem(PRInt32, nsIDOMXULSelectControlItemElement**)’
/Users/Shared/comm-central/mozilla/js/src/xpconnect/src/xpcmodule.h:73: warning: ‘kXPCVARIANT_CID’ defined but not used
Making symlinks to the original object files in the archive libraries ../base/libgkbase_s.a ../generic/libgkgeneric_s.a ../forms/libgkforms_s.a ../style/libgkstyle_s.a ../tables/libgktable_s.a ../xul/base/src/libgkxulbase_s.a ../../content/base/src/libgkconbase_s.a ../../content/canvas/src/libgkconcvs_s.a ../../content/events/src/libgkconevents_s.a ../../content/html/content/src/libgkconhtmlcon_s.a ../../content/html/document/src/libgkconhtmldoc_s.a ../../content/xml/content/src/libgkconxmlcon_s.a ../../content/xml/document/src/libgkconxmldoc_s.a ../../content/xslt/src/base/libtxbase_s.a ../../content/xslt/src/xml/libtxxml_s.a ../../content/xslt/src/xpath/libtxxpath_s.a ../../content/xslt/src/xslt/libtxxslt_s.a ../../content/xbl/src/libgkconxbl_s.a ../../content/xul/document/src/libgkconxuldoc_s.a ../../view/src/libgkview_s.a ../../dom/base/libjsdombase_s.a ../../dom/src/events/libjsdomevents_s.a ../../dom/src/json/libjson_s.a ../../dom/src/jsurl/libjsurl_s.a ../../dom/src/storage/libjsdomstorage_s.a ../../dom/src/offline/libjsdomoffline_s.a ../../dom/src/geolocation/libjsdomgeolocation_s.a ../../dom/system/libdomsystem_s.a ../../dom/src/threads/libdomthreads_s.a ../../dom/indexedDB/libdom_indexeddb_s.a ../../editor/libeditor/text/libtexteditor_s.a ../../editor/libeditor/base/libeditorbase_s.a ../../parser/html/libhtml5p_s.a ../../caps/src/libcaps_s.a ../../dom/system/cocoa/libdomsystemcocoa_s.a ../../media/libvorbis/lib/libvorbis.a ../../media/libogg/src/libogg.a ../../content/media/libgkconmedia_s.a ../../media/libtheora/lib/libtheora.a ../../content/media/ogg/libgkconogg_s.a ../../content/media/webm/libgkconwebm_s.a ../../media/libnestegg/src/libnestegg.a ../../media/libvpx/libvpx.a ../../content/media/wave/libgkconwave_s.a ../../media/libsydneyaudio/src/libsydneyaudio.a ../printing/libgkprinting_s.a ../xul/base/src/tree/src/libgkxultree_s.a ../xul/base/src/grid/libgkxulgrid_s.a ../../content/xul/content/src/libgkconxulcon_s.a ../../content/xul/templates/src/libgkconxultmpl_s.a ../inspector/src/libinspector_s.a ../../content/xtf/src/libgkcontentxtf_s.a ../svg/base/src/libgksvgbase_s.a ../../content/svg/document/src/libgkconsvgdoc_s.a ../../content/svg/content/src/libgkcontentsvg_s.a ../../content/smil/libgkconsmil_s.a ../../js/src/xpconnect/src/libxpconnect_s.a
Undefined symbols:
  "nsEditProperty::mozEditorBogusNode", referenced from:
      nsTextEditRules::CreateBogusNodeIfNeeded(nsISelection*)        in nsTextEditRules.o
      nsEditor::IsMozEditorBogusNode(nsIDOMNode*)       in nsEditor.o
  "nsEditProperty::mozdirty", referenced from:
      nsEditor::MarkNodeDirty(nsIDOMNode*)       in nsEditor.o
ld: symbol(s) not found
collect2: ld returned 1 exit status
make[6]: *** [libgklayout.dylib] Error 1
make[5]: *** [libs] Error 2
make[4]: *** [libs_tier_platform] Error 2
make[3]: *** [tier_platform] Error 2
make[2]: *** [default] Error 2
make[1]: *** [default] Error 2
make: *** [build] Error 2



Reproducible: Always




I have tried deleting the comm-central source directory and rechecking it out, but I still get the aforementioned error. I am also tried several other .mozconfig options, but I don't remember all the iterations.

Comment 1

[Stefan Sitter [:ssitter]]

Yes, comm-central if very broken. Unfortunately the Mozilla Calendar team is not interested in Sunbird anymore. If you want a working Sunbird build try building the source from comm-1.9.2 instead of comm-central.

The error in question is probably caused by Bug 429175 (change https://hg.mozilla.org/mozilla-central/rev/02ca6f9215bc). Partly reverting the patch as noted on <http://www.sunbird-kalender.de/mwiki/index.php/Livingdead> might workaround it. Don't know what the real fix is.

Comment 2

[Nathaniel Madura]

I also have very little interest in Sunbird, The docs I have read suggest that I _have_ to build Sunbird in order to build Lightning, is this not correct?

Comment 3

[Stefan Sitter [:ssitter]]

Lightning can be build together with Thunderbird too, e.g. replace
  ac_add_options --enable-application=calendar
with
  ac_add_options --enable-application=mail
  ac_add_options --enable-calendar

https://developer.mozilla.org/en/Simple_Thunderbird_build#Building_Thunderbird_and_Lightning

Most probably it can be build with SeaMonkey too, but I have not tested myself.

However, to build Lightning on comm-central you'll need to wait until e.g. Bug 576746 is fixed.

Comment 4

[Edmund Wong (:ewong)]

Fwiw, this also happens on a Win7 platform w/ VS2010.

Comment 5

[Edmund Wong (:ewong)]

Attachment: Workaround patch to avoid the unresolved external symbols errors.

This isn't a patch that solves this problem.  It's only to a workaround
to allow Sunbird to build.  There is a problem with adding this line
MOZ_PLAINTEXT_EDITOR_ONLY=1 to any product (well, at least on suite and
calendar.  I'm guessing TB is also affected).  

Credit goes to khuey.

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 512721 [details] [diff] [review]
Workaround patch to avoid the unresolved external symbols errors.

This goes way way back to 2004 when the initial mozconfig was added for sunbird. I think we can remove this variable. Please get rid of the whole line instead of commenting it out.

r=philipp,a=NPOTB for checkin on comm-central/comm-1.9.2

Comment 7

[Edmund Wong (:ewong)]

Attachment: Removed MOZ_PLAINTEXT_EDITOR_ONLY=1 from confvars.sh.

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm central, rev 40c600b1bf1f and comm-1.9.2 rev 33a97869134d

-> FIXED