580738 - XP styling of Firefox Menu

Status: RESOLVED INCOMPLETE

(Firefox :: Theme, defect)

Description

[Peter Henkel [:Terepin]]

User-Agent:       Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; rv:2.0b3pre) Gecko/20100721 Minefield/4.0b3pre
Build Identifier: Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; rv:2.0b3pre) Gecko/20100721 Minefield/4.0b3pre

See bug 571784 for details.

Reproducible: Always

Comment 1

[Alex Faaborg [:faaborg] (Firefox UX)]

Confirming and setting to block the overall project bug 556174.  I'll come back later to post mockups.

Comment 2

[alex_mayorga]

Attachment: Black font remains on selected menus

On Mozilla/5.0 (Windows NT 6.0; rv:2.0b5pre) Gecko/20100820 Minefield/4.0b5pre ID:20100820041049 all menu items except "New Tab" and "Options..." keep a black font when hovered.
Font color should change to white for hovered menu items.
Is this the right bug or another one is needed?

Comment 3

[alex_mayorga]

The "split-menu button" jumplist? doesn't exist on "Windows Classic"
theme (see https://bugzilla.mozilla.org/attachment.cgi?id=467794).
I'm not UI expert, but I believe for classic theme only the elements on
Classic.xaml should be used (see http://msdn.microsoft.com/en-us/library/aa970773.aspx)

Comment 4

[Peter Henkel [:Terepin]]

Wrong bug. The correct one is bug 580740.

Comment 5

[Darren Kalck [:D-Kalck]]

(In reply to comment #2)
> Created attachment 467761 [details]
> Black font remains on selected menus
> 
> On Mozilla/5.0 (Windows NT 6.0; rv:2.0b5pre) Gecko/20100820 Minefield/4.0b5pre
> ID:20100820041049 all menu items except "New Tab" and "Options..." keep a black
> font when hovered.
> Font color should change to white for hovered menu items.
> Is this the right bug or another one is needed?

That's bug 589121

Comment 6

[Antwan]

Attachment: Firefox 4 button fitted for WinXP

Hi,

First please notice this is my first contribution, at first I only read comments, still I don't really know if my post is appropriate here or it should be in another bug or on the wiki, so I apologies in advance.

Anyway, I just have a feedback about the Firefox button on Windows XP, because nightlies after nightlies, I start to believe something has not been taken in account.

According the mockups, the button should be like this : 
https://wiki.mozilla.org/Firefox/4.0_Windows_Theme_Mockups#Large_Button_Mode_with_Firefox_Button

IMO the aim of this mockup is not to show the button should be enlargen, it is to focus on the fact that it should _fit_ the OS, ie the Firefox button should just look like the close/minimize/maximize buttons and should not touch the top edge of the title bar (look attachement to see my point)

Therefore, the button should also be different on Win XP w/ classic theme, and on WinVista without aero.

If UI developpements still continue in this direction, there will be inconsistencies on other systems than Win7, because currently the button just fits this OS.
Hacking title bar is not usual on XP themes, therefore it should be done wisely.


Please tell me what you think of this, and if it is doable for 4.0.

Comment 7

[Peter Henkel [:Terepin]]

This bug is about Firefox Menu, not Firefox Button.

Comment 8

[Antwan]

right, I moved my comment on bug 594264