Closed
Bug 580748
Opened 15 years ago
Closed 15 years ago
"timeStamp" -> "timestamp" in the Console
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 4.0b3
People
(Reporter: pcwalton, Assigned: pcwalton)
Details
Attachments
(1 file)
|
491 bytes,
patch
|
Gavin
:
review+
beltzner
:
approval2.0+
|
Details | Diff | Splinter Review |
In the Console, there are two paths in constructing message objects: the HUDConsole() constructor and the createLogNode() method of the HUDService object. One of them sets a field called "timeStamp", while the other chooses "timestamp". "timeStamp" is an identifier used nowhere else in the file.
It will simplify the header code slightly to use one identifier in all places. The attached patch fixes this.
Requesting approval for Fx4.
Attachment #459120 -
Flags: review?(dtownsend)
|
Assignee | |
Comment 1•15 years ago
|
||
Justification of approval: Headers for the Console are part of the UI for the Console, bug 559481. I am requesting blocking status for Firefox 4 for the Console UI.
|
|
||
Updated•15 years ago
|
blocking2.0: --- → ?
|
||
Comment 2•15 years ago
|
||
When requesting blocking please provide an explanation of the user impact of the bug.
|
|
Assignee | |
Comment 3•15 years ago
|
||
This bug is not blocking. I can work around it. However, the UI is blocking, so I am requesting approval for this bug to simplify the UI code I'm about to write.
|
|
Assignee | |
Updated•15 years ago
|
blocking2.0: ? → ---
|
||
Updated•15 years ago
|
Attachment #459120 -
Flags: review?(dtownsend) → review+
|
||
Updated•15 years ago
|
Attachment #459120 -
Flags: approval2.0+
|
|
Assignee | |
Updated•15 years ago
|
Keywords: checkin-needed
|
|
||
Comment 4•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b3
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•