580828 - Remove AVMFEATURE_API_VERSIONING

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Steven Johnson]

fix buf https://bugzilla.mozilla.org/show_bug.cgi?id=559994 (http://hg.mozilla.org/tamarin-redux/rev/29990aab21ef) made it obsolete.

Comment 1

[Steven Johnson]

Attachment: Patch

Comment 2

[Rick Reitmaier]

Comment on attachment 459213 [details] [diff] [review]
Patch

+r Not quite sure what this does ... 'apiversioning = True'  but assume that the change (i.e. s/False/True/) was needed for something.

Comment 3

[Steven Johnson]

(In reply to comment #2)
> +r Not quite sure what this does ... 'apiversioning = True'  but assume that
> the change (i.e. s/False/True/) was needed for something.

Good catch, that shouldn't be there, otherwise we'll get failures in the unit tests. I'll push without that change.

Comment 4

[Steven Johnson]

pushed as http://hg.mozilla.org/tamarin-redux/rev/5857e7f66e90

Comment 5

[Chris Peyer]

Attachment: Remove api versioning checks in test code and buildbot

API versioning is now always enabled.  No need to build & test separately in deep phase.  This patch removes all api-versioning related features in buildbot and the acceptance scripts.

Comment 6

[Brent Baker]

Comment on attachment 460345 [details] [diff] [review]
Remove api versioning checks in test code and buildbot

Probably want to leave the API testing in the argo.py configuration since it is still valid in that repo

Comment 7

[Brent Baker]

Comment on attachment 460345 [details] [diff] [review]
Remove api versioning checks in test code and buildbot

Chris doesn't look like this patch has been pushed yet, API testing in the deep phase is failing since it is no longer valid.

Comment 8

[Chris Peyer]

Pushed api testing patch: http://hg.mozilla.org/tamarin-redux/rev/8ff7caaccb2d