Remove AVMFEATURE_API_VERSIONING

VERIFIED FIXED

Status

defect
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: stejohns, Assigned: stejohns)

Tracking

Details

Attachments

(2 attachments)

Posted patch PatchSplinter Review
Assignee: nobody → stejohns
Attachment #459213 - Flags: review?(rreitmai)
Comment on attachment 459213 [details] [diff] [review]
Patch

+r Not quite sure what this does ... 'apiversioning = True'  but assume that the change (i.e. s/False/True/) was needed for something.
Attachment #459213 - Flags: review?(rreitmai) → review+
(In reply to comment #2)
> +r Not quite sure what this does ... 'apiversioning = True'  but assume that
> the change (i.e. s/False/True/) was needed for something.

Good catch, that shouldn't be there, otherwise we'll get failures in the unit tests. I'll push without that change.
pushed as http://hg.mozilla.org/tamarin-redux/rev/5857e7f66e90
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
API versioning is now always enabled.  No need to build & test separately in deep phase.  This patch removes all api-versioning related features in buildbot and the acceptance scripts.
Attachment #460345 - Flags: review?(brbaker)
Comment on attachment 460345 [details] [diff] [review]
Remove api versioning checks in test code and buildbot

Probably want to leave the API testing in the argo.py configuration since it is still valid in that repo
Attachment #460345 - Flags: review?(brbaker) → review+
Comment on attachment 460345 [details] [diff] [review]
Remove api versioning checks in test code and buildbot

Chris doesn't look like this patch has been pushed yet, API testing in the deep phase is failing since it is no longer valid.
Pushed api testing patch: http://hg.mozilla.org/tamarin-redux/rev/8ff7caaccb2d
Status: RESOLVED → VERIFIED
OS: Mac OS X → All
You need to log in before you can comment on or make changes to this bug.