Msg Pane context item Reply to Sender replies to newsgroup

VERIFIED FIXED in Future

Status

MailNews Core
Composition
P3
major
VERIFIED FIXED
18 years ago
10 years ago

People

(Reporter: Eugene Savitsky, Assigned: (not reading, please use seth@sspitzer.org instead))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nsbeta1+ 1/25])

Attachments

(2 attachments)

(Reporter)

Description

18 years ago
In newsgroup press right mouse *in the message body window* and choose reply to 
sender only.

It replies to the newsgroup, just like reply to newsgroup.

RTM++?
(Reporter)

Updated

18 years ago
Priority: P3 → P2

Comment 1

18 years ago
Using oct25 commercial branch build, win98:
Reply to Sender menu items (main menu and context menu) work to reply to the
email address of the poster.
Reply button on the toolbar mistakenly shows a tooltip "Reply to Sender only"
when in a newsgroup.
The Reply button is indeed doing the right thing, defaulting to reply to newsgroup.
This is a bug whereas the tooltip is wrong in the newsgroup context.

QA Contact: esther → nbaca

Comment 2

18 years ago
.
Assignee: mscott → ducarroz
Component: Mail Back End → Composition
QA Contact: nbaca → esther

Updated

18 years ago
QA Contact: esther → nbaca
The report is right, the contextual menu "Reply to Sender" won't reply to the
sender but the news group. Reassign to varada
Assignee: ducarroz → varada
(Reporter)

Comment 4

17 years ago
Nominating for nsbeta1 since the UI with this bug is broken + it is very annoing.
Keywords: nsbeta1

Comment 5

17 years ago
Platform, OS -> All.

I will have a go at this, I am not sure if I can fix it but I'll do my best.
OS: Windows 2000 → All
Hardware: PC → All

Comment 6

17 years ago
I've been looking into this for a while now and I've realized that we never
implemented the Reply to Sender feature back-end. I am not 100%, but I think
that is the problem.

http://lxr.mozilla.org/seamonkey/source/mailnews/base/resources/content/mailWindowOverlay.js#329

In MsgReplyGroup() we send msgComposeType.ReplyToGroup as our composetype, and
in MsgReplyAll() we send msgComposeType.ReplyAll, but in MsgReplySender() we
just send plain msgComposeType.Reply.

Shouldn't it be msgComposeType.ReplySender or something?

Either this is just plain inconsitent code, or the Replt to Sender feature has
been broken forever.

Could someone please clarify this for me?

Updated

17 years ago
Summary: reply to sender replies to newsgroup → Msg Pane context item Reply to Sender replies to newsgroup

Comment 7

17 years ago
marking nsbeta1+ and moving to mozilla0.9
Priority: P2 → P3
Whiteboard: [nsbeta1+]
Target Milestone: --- → mozilla0.9
adding ducarroz and seth in case either of you guys can help hwaara fix this ;-)

Comment 9

17 years ago
marking nsbeta1- though it would be great if hwaara fixed this.
Keywords: nsbeta1 → nsbeta1-
Whiteboard: [nsbeta1+] → [nsbeta1+ 1/25]
Target Milestone: mozilla0.9 → Future
(Reporter)

Comment 10

17 years ago
So, then I suggest to remove the Reply to sender option, so nobody get's confused.

Comment 11

17 years ago
I could go either way; fix it or remove it.

If you want me to fix it then I need a mailnews guy to answer my previous question.
You are totally right, we need to implement a RelyToSender. The easy way is too
look all around the code in mailnews/compose for "ReplyToSenderAndGroup" and do
about the same with "RelyToSender". First step would be to add it to
nsIMsgComposeParams.idl...

Comment 13

17 years ago
I've been looking around and it spreads from XUL/JS to cpp to lots of cpp files.
I am not sure I am capable to do this...
Maybe you can do the front end part (XUL/JS) and let varada do the backend side
(idl, cpp). FYI, varada is on vacation.
...or if you you want, I can show you what to do exactly.

Comment 16

17 years ago
That would be very nice, then I could at least have a try! Please send me an
email about it.

Comment 17

17 years ago
Created attachment 23654 [details] [diff] [review]
[Patch] Partial fix

Comment 18

17 years ago
This patch is NOT yet done. All it does is to implement the ReplyToSender
functionality and backend code in mailnews. It now works to reply to a sender in
a newsgroup.

What it doesn't yet do is to rename the "Reply to Sender" menuitem to just
"Reply" when a non-newsgroup message is context-clicked. I would very much want
to know how to do this, but haven't gotten any help so far.

Please email me if you think you know or have any comments.. Meanwhile, I will
try to figure it out bt myself...
here's a fix, based on hwaara's patch. 

1) reply to sender (when reading news) goes to the author of the post only.
2) tooltip for "Reply" is "Reply to the message", like 4.x
3) "Reply to Sender" is "Reply to Sender Only", like in 4.x

hwaara, please test and review.
Created attachment 23902 [details] [diff] [review]
fix based on hwaara's fix
Look goods. R=ducarroz

Comment 22

17 years ago
I was unable to patch my tree today, but the patch looks good to me! 

r=hwaara
taking from varada.
Assignee: varada → sspitzer

Comment 24

17 years ago
sr=bienvenu
fixed.  thanks for the initial patch, hwaara.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 26

17 years ago
I think we should show just "Reply" when the context click is on a usual email
message.
VERIFIED FIXED.  Context clicking a message and hitting "Reply to Sender" does
that, and just that on build 2001021708 (Windows NT 4.0), build 2001021617
(MacOS) and build 2001021608 (RedHat 7.0).
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.