If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Race condition in Test Pilot experiment details page

RESOLVED FIXED in 1.3

Status

Mozilla Labs Graveyard
Test Pilot
P1
critical
RESOLVED FIXED
7 years ago
a year ago

People

(Reporter: Jono Xia, Assigned: Jono Xia)

Tracking

Bug Flags:
in-testsuite ?
in-litmus -

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
There's a race condition in the experiment details page, because in experiment-page.js in loadExperimentPage(), the asynchronous function getWebContent() is called and then onPageLoad() is called without waiting for getWebContent() to return.  This can cause onPageLoad() to fail if a <div> or something that it's expecting to be there hasn't been added yet.

Updated

7 years ago
Blocks: 580344
(Assignee)

Comment 1

7 years ago
Created attachment 459275 [details] [diff] [review]
Patch fixing the bug

The bug is fixed in the test pilot repository by http://hg.mozilla.org/labs/testpilot/rev/71df3564dcff

Attached a patch with the change; this patch should be reviewed for inclusion in Firefox 4 beta 3.
Attachment #459275 - Flags: review?(dtownsend)

Updated

7 years ago
Flags: in-testsuite?
Flags: in-litmus?
Target Milestone: -- → 1.3

Updated

7 years ago
Severity: normal → critical
Priority: -- → P1
Attachment #459275 - Flags: review?(dtownsend) → review+
Attachment #459275 - Flags: approval2.0+
Fixed for b3: http://hg.mozilla.org/mozilla-central/rev/097c27ffb22d
Assignee: nobody → jdicarlo
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
no test case given. Also, race condition test don't usually make for good manual regression tests.  in-litmus-
Flags: in-litmus? → in-litmus-
Product: Mozilla Labs → Mozilla Labs Graveyard
You need to log in before you can comment on or make changes to this bug.