Closed
Bug 580856
Opened 14 years ago
Closed 14 years ago
Race condition in Test Pilot experiment details page
Categories
(Mozilla Labs Graveyard :: Test Pilot, defect, P1)
Mozilla Labs Graveyard
Test Pilot
Tracking
(Not tracked)
RESOLVED
FIXED
1.3
People
(Reporter: jono, Assigned: jono)
References
Details
Attachments
(1 file)
2.05 KB,
patch
|
mossop
:
review+
mossop
:
approval2.0+
|
Details | Diff | Splinter Review |
There's a race condition in the experiment details page, because in experiment-page.js in loadExperimentPage(), the asynchronous function getWebContent() is called and then onPageLoad() is called without waiting for getWebContent() to return. This can cause onPageLoad() to fail if a <div> or something that it's expecting to be there hasn't been added yet.
The bug is fixed in the test pilot repository by http://hg.mozilla.org/labs/testpilot/rev/71df3564dcff Attached a patch with the change; this patch should be reviewed for inclusion in Firefox 4 beta 3.
Attachment #459275 -
Flags: review?(dtownsend)
Updated•14 years ago
|
Flags: in-testsuite?
Flags: in-litmus?
Target Milestone: -- → 1.3
Updated•14 years ago
|
Severity: normal → critical
Priority: -- → P1
Updated•14 years ago
|
Attachment #459275 -
Flags: review?(dtownsend) → review+
Updated•14 years ago
|
Attachment #459275 -
Flags: approval2.0+
Comment 2•14 years ago
|
||
Fixed for b3: http://hg.mozilla.org/mozilla-central/rev/097c27ffb22d
Assignee: nobody → jdicarlo
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 3•14 years ago
|
||
no test case given. Also, race condition test don't usually make for good manual regression tests. in-litmus-
Flags: in-litmus? → in-litmus-
Updated•8 years ago
|
Product: Mozilla Labs → Mozilla Labs Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•