Closed Bug 580856 Opened 14 years ago Closed 14 years ago

Race condition in Test Pilot experiment details page

Categories

(Mozilla Labs Graveyard :: Test Pilot, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jono, Assigned: jono)

References

Details

Attachments

(1 file)

There's a race condition in the experiment details page, because in experiment-page.js in loadExperimentPage(), the asynchronous function getWebContent() is called and then onPageLoad() is called without waiting for getWebContent() to return.  This can cause onPageLoad() to fail if a <div> or something that it's expecting to be there hasn't been added yet.
Blocks: 580344
The bug is fixed in the test pilot repository by http://hg.mozilla.org/labs/testpilot/rev/71df3564dcff

Attached a patch with the change; this patch should be reviewed for inclusion in Firefox 4 beta 3.
Attachment #459275 - Flags: review?(dtownsend)
Flags: in-testsuite?
Flags: in-litmus?
Target Milestone: -- → 1.3
Severity: normal → critical
Priority: -- → P1
Attachment #459275 - Flags: review?(dtownsend) → review+
Attachment #459275 - Flags: approval2.0+
Fixed for b3: http://hg.mozilla.org/mozilla-central/rev/097c27ffb22d
Assignee: nobody → jdicarlo
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
no test case given. Also, race condition test don't usually make for good manual regression tests.  in-litmus-
Flags: in-litmus? → in-litmus-
Product: Mozilla Labs → Mozilla Labs Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: