580870 - Alias gBrowser to the tabcandy context to remove getCurrentWindow

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Ed Lee :Mardak]

There's a number of calls to getCurrentWindow() that could be cached and stored as gWindow as that shouldn't change for a given tabcandy view in a browser window.

Comment 1

[Ed Lee :Mardak]

Attachment: v1

Comment 2

[Ed Lee :Mardak]

http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/41ec081e9f2c
Add aliases for gWindow, gBrowser, gTabDeck, gTabFrame for the tabcandy chrome context. Update uses and simplify some code like removing Navbar.

Comment 3

[Ian Gilman [:iangilman]]

Comment on attachment 459288 [details] [diff] [review]
v1

Mardak, this is awesome! Much cleaner. 

My only comment is that maybe gTabDeck and gTabFrame should be named so that it's clear that they refer to the Tab Candy UI (rather than the tab bar). Maybe gTabViewDeck?

Comment 4

[Ed Lee :Mardak]

http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/ab653b08b29e
Followup bug 580870 to rename gTabDeck/gTabFrame to gTabView*.

Comment 5

[(no longer active)]

Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".