580882 - Narcissus DOM support

Status: RESOLVED FIXED

(Other Applications Graveyard :: Narcissus, defect)

Description

[Tom Austin]

Currently, Narcissus does not interact with the DOM.  It needs to be updated so that it can be used within a browser.

Comment 1

[Tom Austin]

Attachment: Narcissus browser support patch

This patch replaces the global object with a proxy that will reach to the underlying JS engine when needed, allowing it to use browser-specific functions when available.  This approach would allow the user to get at the underlying Narcissus constructs.  I intend to file a separate bug for that.

A number of new unit tests are passing.  A few new ones are also failing, mostly due to the 'watch' construct.

Comment 2

[Tom Austin]

Attachment: Updated patch to work with modularized Narcissus

Comment 3

[Andreas Gal :gal]

Comment on attachment 462627 [details] [diff] [review]
Updated patch to work with modularized Narcissus

We could wrap the global object with a proxy. What do you think?

Comment 4

[Dave Herman [:dherman]]

Comment on attachment 462627 [details] [diff] [review]
Updated patch to work with modularized Narcissus

>diff --git a/js/narcissus/browser.js b/js/narcissus/browser.js
>new file mode 100644
>--- /dev/null
>+++ b/js/narcissus/browser.js

The makefile changes introduced in bug 583281 create symlinks for all files in narcissus/js*.js and the njs script depends on these. Is the Narcissus.browser module only enabled in the browser?

Dave

Comment 5

[Tom Austin]

Yup, the browser.js file is only needed for the browser.

Comment 6

[Dave Herman [:dherman]]

Okay. Our file naming convention is a little goofy, but I guess it's not a big deal. Maybe just add a comment to js/src/shell/Makefile.in explaining that js*.js covers the shell-specific files and only the shell-specific files?

Dave

Comment 7

[Tom Austin]

Attachment: Replacement patch for including browser support

Changes from previous patch:
*Redesigned browser.js to rely less on specific names
*Renamed browser.js to jsbrowser.js

Comment 8

[Andreas Gal :gal]

Comment on attachment 463013 [details] [diff] [review]
Replacement patch for including browser support

Comment style:

/*
 *
 */

We should ideally not patch the original window object.

Comment 9

[Tom Austin]

Attachment: Partial patch reorganizing proxies

Comment 10

[Tom Austin]

Attachment: Update patch removes need for jsbrowser.js

The new patch uses a proxy for native code functions.  As part of this, the proxy setup has been refactored.

Comment 11

[Tom Austin]

Comment on attachment 464285 [details] [diff] [review]
Update patch removes need for jsbrowser.js

Andreas approved with some changes:
* changed 'realGlobal' to 'hostGlobal'
* made notes of spidermonkey specific functionality

Comment 12

[Tom Austin]

Changelist: http://hg.mozilla.org/tracemonkey/rev/b5abd91bc7fa