If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Directly call loadOneTab instead of Tabs.open

RESOLVED FIXED

Status

Firefox Graveyard
Panorama
RESOLVED FIXED
7 years ago
2 years ago

People

(Reporter: Mardak, Assigned: Mardak)

Tracking

Dependency tree / graph

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Can also avoid making use of the wrapped tab tab.
(Assignee)

Comment 1

7 years ago
Created attachment 459323 [details] [diff] [review]
v1
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #459323 - Flags: review?(ian)
(Assignee)

Updated

7 years ago
Depends on: 580870
(Assignee)

Comment 2

7 years ago
http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/1832de5a5a95
Remove Tabs.open and BrowserWindow.addTab and directly deal with xul tabs.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
Attachment #459323 - Flags: review?(ian) → feedback?(ian)
Comment on attachment 459323 [details] [diff] [review]
v1

Looks good. One comment: you're using "let" instead of "var" at one point; I thought we had settled to stick with var?
Attachment #459323 - Flags: feedback?(ian) → feedback+
(Assignee)

Comment 4

7 years ago
Oh, I guess we can switch it back to var. But "let is the new var" ;) Most new code in firefox is using let I believe.
(In reply to comment #4)
> Oh, I guess we can switch it back to var. But "let is the new var" ;) Most new
> code in firefox is using let I believe.

Just discussed it with mitcho and gavin. Gavin's recommendation is to leave all the existing vars but use let for all new code. Sounds good to me.

Comment 6

7 years ago
Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".
Component: TabCandy → TabCandy
Product: Mozilla Labs → Firefox
Target Milestone: -- → ---
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.