Closed Bug 580957 Opened 14 years ago Closed 14 years ago

Make the toolbarbutton label replication in the customization panel work for the bookmarks button, too.

Categories

(Toolkit :: Toolbars and Toolbar Customization, defect)

Product:
Toolkit
Component:
Toolbars and Toolbar Customization
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b4

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(1 file, 1 obsolete file)

v2
3.85 KB, patch
dao
: review+
Gavin
: approval2.0+
Details | Diff | Splinter Review
Attached patch v1 (obsolete) — — Splinter Review 
The changes in bug 573326 don't work for the new bookmarks button, since it doesn't expect a toolbaritem around the button.
Attachment #459360 - Flags: review?(dao)
Comment on attachment 459360 [details] [diff] [review]
v1

This seems to be too much tailored to browser internals.

I think we should:

1. Hide all .toolbarbutton-text, regardless of the widget structure.
2. Set the title attribute on the bookmarks menu and the back/forward widgets.
Attachment #459360 - Flags: review?(dao) → review-
Should I put title="&backCmd.label;/&forwardCmd.label;" on the back/forward toolbaritem, or should I create a new entity?
You should create a new entity.
Attached patch v2 — — Splinter Review 

        Attachment #459360 -
        Attachment is obsolete: true

        Attachment #462400 -
        Flags: review?(dao)

    
  

        Attachment #462400 -
        Flags: review?(dao) → review+

    
  

        Attachment #462400 -
        Flags: approval2.0?

        Attachment #462400 -
        Flags: approval2.0? → approval2.0+

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/14a434e46cce
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b4

    
    

    
  
Now that we have an improved bookmarks button, shouldn't the old one be removed? It's basically become useless. The only advantage it has compared to the new one is that it only takes one click. This could be given to the new one by middle clicking it. 

And it's kind of confusing having two "bookmarks" in the toolbar customization window.

    
    

    
  
I don't know. Please file a new bug for that and CC Marco and Stephen.

    
    

    
  
bug 584669
Don't know which Marco to CC

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: