Make the toolbarbutton label replication in the customization panel work for the bookmarks button, too.

RESOLVED FIXED in mozilla2.0b4

Status

()

Toolkit
Toolbars and Toolbar Customization
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: mstange, Assigned: mstange)

Tracking

Trunk
mozilla2.0b4
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 years ago
Created attachment 459360 [details] [diff] [review]
v1

The changes in bug 573326 don't work for the new bookmarks button, since it doesn't expect a toolbaritem around the button.
Attachment #459360 - Flags: review?(dao)
Comment on attachment 459360 [details] [diff] [review]
v1

This seems to be too much tailored to browser internals.

I think we should:

1. Hide all .toolbarbutton-text, regardless of the widget structure.
2. Set the title attribute on the bookmarks menu and the back/forward widgets.
Attachment #459360 - Flags: review?(dao) → review-
(Assignee)

Comment 2

8 years ago
Should I put title="&backCmd.label;/&forwardCmd.label;" on the back/forward toolbaritem, or should I create a new entity?
You should create a new entity.
(Assignee)

Comment 4

8 years ago
Created attachment 462400 [details] [diff] [review]
v2
Attachment #459360 - Attachment is obsolete: true
Attachment #462400 - Flags: review?(dao)

Updated

8 years ago
Attachment #462400 - Flags: review?(dao) → review+
(Assignee)

Updated

8 years ago
Attachment #462400 - Flags: approval2.0?
Attachment #462400 - Flags: approval2.0? → approval2.0+
(Assignee)

Comment 5

8 years ago
http://hg.mozilla.org/mozilla-central/rev/14a434e46cce
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b4

Comment 6

8 years ago
Now that we have an improved bookmarks button, shouldn't the old one be removed? It's basically become useless. The only advantage it has compared to the new one is that it only takes one click. This could be given to the new one by middle clicking it. 

And it's kind of confusing having two "bookmarks" in the toolbar customization window.
(Assignee)

Comment 7

8 years ago
I don't know. Please file a new bug for that and CC Marco and Stephen.

Comment 8

8 years ago
bug 584669
Don't know which Marco to CC
You need to log in before you can comment on or make changes to this bug.