Closed Bug 580995 Opened 13 years ago Closed 13 years ago

Fennec opens new tabs too aggressively

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: mfinkle, Assigned: mfinkle)

References

Details

Attachments

(1 file)

patch
963 bytes, patch
vingtetun
: review+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
Fennec makes sure certain webpages are opened in "local" tabs . See bug 552832

The current behavior is such that a new tab is opened for any page (about: or chrome:) that should be in a local page, regardless of whether the current tab is "local" or not. This ends up opening a lot of tabs.

This patch will reuse an existing "local" tab instead of opening a new tab.
Attachment #459406 - Flags: review?(21)
Comment on attachment 459406 [details] [diff] [review]
patch

A nice win, all these tabs were annoying
Attachment #459406 - Flags: review?(21) → review+
pushed:
http://hg.mozilla.org/mobile-browser/rev/50aba28a58bf
Assignee: nobody → mark.finkle
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b2pre) Gecko/2010723 Namoroka/4.0b2pre Fennec/2.0a1pre

and

Mozilla/5.0 (Android; U; Linux armv71; en-US; rv:2.0b2pre) Gecko/20100723 Namoroka/4.0b2pre Fennec/2.0a1pre
Status: RESOLVED → VERIFIED
Flags: in-litmus?
Assignee: mark.finkle → nhirata.bugzilla
Assignee: nhirata.bugzilla → mark.finkle
Flags: in-litmus? → in-litmus?(nhirata.bugzilla)
Litmus test created for this specific issue which overrides bug 552832.

https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=12940
Flags: in-litmus?(nhirata.bugzilla) → in-litmus+
You need to log in before you can comment on or make changes to this bug.