581023 - Firefox Button vertical position is off on maximized windows when advanced appearance setting 'border padding' is set to a non-default value

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[marcus]

User-Agent:       Mozilla/5.0 (Windows; Windows NT 6.1; rv:2.0b3pre) Gecko/20100722 Minefield/4.0b3pre
Build Identifier: Mozilla/5.0 (Windows; Windows NT 6.1; rv:2.0b3pre) Gecko/20100722 Minefield/4.0b3pre

Changing Border Padding size (Windows Control Panel > Appearance and Personalization > Personalization > Window Color and Appearance > Advanced appearance settings...) causes the Firefox Button changes its position in the title bar when the browser window is maximized

Reproducible: Always

Steps to Reproduce:
1.Change Border Padding size
2.Maximize Firefox window
Actual Results:  
If the Border Padding size is less than 4, the Firefox Button will be moved down, creating a small gap (see picture)
If the Border Padding size is more than 4, the Firefox Button will be moved up, cropping part of the button

Expected Results:  
The Firefox Button should be in the same position

Comment 1

[marcus]

Attachment: Screenshot

Comment 2

[Jim Mathies [:jimm]]

This should block as it could be quite annoying for users who prefer maximized browser windows (and shouldn't be too hard to address).

Comment 3

[Tan Wei Lin Jason [:Ryuji]]

This should block the meta bug for Firefox, bug 556174

Comment 4

[Bill Gianopoulos [:WG9s]]

The issue here is this code:

https://bug574821.bugzilla.mozilla.org/attachment.cgi?id=454364

which was added for bug 574821.

The magic 8px number here really needs to be the size of the vertical refresh margin.

Comment 5

[Bill Gianopoulos [:WG9s]]

I tried doing this by using the same approach used for bug 575245, i.e. removing the css fix from bug 574821 and instead adjust mNonClientOffset.top.

This resulted in perfect display, but unfortunately, the window control buttons in the upper right corner (minimize, maximize, close) were non-functional.

At first I thought this was because I had changed the offset so much that although the buttons were still positioned as expected the hot area for the mouse selection was off the screen top.

I tried just adjusting the offset by one pixel, which should have at least left some area of the button that worked, but it did not.  I have no idea why this happens.

Comment 6

[Jim Mathies [:jimm]]

(In reply to comment #5)
> I tried doing this by using the same approach used for bug 575245, i.e.
> removing the css fix from bug 574821 and instead adjust mNonClientOffset.top.
> 
> This resulted in perfect display, but unfortunately, the window control buttons
> in the upper right corner (minimize, maximize, close) were non-functional.
> 
> At first I thought this was because I had changed the offset so much that
> although the buttons were still positioned as expected the hot area for the
> mouse selection was off the screen top.
> 
> I tried just adjusting the offset by one pixel, which should have at least left
> some area of the button that worked, but it did not.  I have no idea why this
> happens.

The css was a temp fix when we landed the titlebar code. The real fix is to set the upper margin for content on the window using the system's border padding. That's what the patch in bug 575870 does, in connection with the addition of new style properties via bug 574454. (These should land sometime next week.)

Comment 8

[Jim Mathies [:jimm]]

Fixed by the landings in bug 575870 & bug 574454.