Closed
Bug 581036
Opened 16 years ago
Closed 16 years ago
nsTimerImpl.cpp compilation fails on mingw.
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b3
People
(Reporter: jacek, Assigned: jacek)
Details
Attachments
(1 file)
|
452 bytes,
text/plain
|
bzbarsky
:
review+
benjamin
:
approval2.0+
|
Details |
After landing the second part of bug 558306, nsTimerImpl.cpp no longer compiles on mingw with an error:
/home/jacek/mozilla-build/mozilla-central/xpcom/threads/nsTimerImpl.cpp: In member function 'void nsTimerImpl::Fire()':
/home/jacek/mozilla-build/mozilla-central/xpcom/threads/nsTimerImpl.cpp:396:36: error: cannot call constructor 'mozilla::TimeStamp::TimeStamp' directly
/home/jacek/mozilla-build/mozilla-central/xpcom/threads/nsTimerImpl.cpp:396:36: error: for a function-style cast, remove the redundant '::TimeStamp'
The trivial fix is attached.
|
||
Comment 1•16 years ago
|
||
Comment on attachment 459453 [details]
fix v1.0
Thank you for the patch!
Attachment #459453 -
Flags: review+
Attachment #459453 -
Flags: approval2.0?
|
||
Updated•16 years ago
|
Attachment #459453 -
Flags: approval2.0? → approval2.0+
|
||
Comment 2•16 years ago
|
||
Assignee: nobody → jacek
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b3
You need to log in
before you can comment on or make changes to this bug.
Description
•