nsTimerImpl.cpp compilation fails on mingw.

RESOLVED FIXED in mozilla2.0b3

Status

()

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: jacek, Assigned: jacek)

Tracking

Trunk
mozilla2.0b3
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

452 bytes, text/plain
bzbarsky
: review+
benjamin
: approval2.0+
Details
(Assignee)

Description

9 years ago
Created attachment 459453 [details]
fix v1.0

After landing the second part of bug 558306, nsTimerImpl.cpp no longer compiles on mingw with an error:

/home/jacek/mozilla-build/mozilla-central/xpcom/threads/nsTimerImpl.cpp: In member function 'void nsTimerImpl::Fire()':
/home/jacek/mozilla-build/mozilla-central/xpcom/threads/nsTimerImpl.cpp:396:36: error: cannot call constructor 'mozilla::TimeStamp::TimeStamp' directly
/home/jacek/mozilla-build/mozilla-central/xpcom/threads/nsTimerImpl.cpp:396:36: error:   for a function-style cast, remove the redundant '::TimeStamp'

The trivial fix is attached.
Comment on attachment 459453 [details]
fix v1.0

Thank you for the patch!
Attachment #459453 - Flags: review+
Attachment #459453 - Flags: approval2.0?

Updated

9 years ago
Attachment #459453 - Flags: approval2.0? → approval2.0+

Comment 2

9 years ago
http://hg.mozilla.org/mozilla-central/rev/d77a6ca0dc45
Assignee: nobody → jacek
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b3
You need to log in before you can comment on or make changes to this bug.