581044 - Use square toolbarbuttons in the Places library window

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Markus Stange [:mstange]]

Attachment: v1

Now that the main window buttons aren't round any more, those in the Places library shouldn't be either.

Comment 1

[Dão Gottwald [:dao]]

Comment on attachment 459457 [details] [diff] [review]
v1

> #back-button > .toolbarbutton-icon {
>+  -moz-margin-start: 3px !important;
>   -moz-margin-end: 2px !important;
> }
> 
> #forward-button > .toolbarbutton-icon {
>   -moz-margin-start: 2px !important;
>+  -moz-margin-end: 3px !important;
> }

Please explain?

Comment 2

[Markus Stange [:mstange]]

Further up, a horizontal margin of 4px is set on the toolbarbutton-icons, so this just decreases the outer margins by 1px. Now their width matches the width of the small back/forward button pair in the main browser window. (Almost, at least - the forward button in the main browser window is 1px shorter.)

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 459457 [details] [diff] [review]
v1

> #placesToolbar > toolbarbutton {
>   list-style-image: url("chrome://browser/skin/places/toolbar.png");
>-  margin: 4px 6px 5px;
>-  padding: 1px 5px;
>+  margin: 4px 4px 5px;
>+  padding: 1px 3px;
>   -moz-border-radius: 100%;

remove this line

Comment 4

[Markus Stange [:mstange]]

Attachment: v2

Comment 5

[Markus Stange [:mstange]]

http://hg.mozilla.org/mozilla-central/rev/8522bc32ad34