If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Use square toolbarbuttons in the Places library window

RESOLVED FIXED in Firefox 4.0b4

Status

()

Firefox
Theme
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: mstange, Assigned: mstange)

Tracking

Trunk
Firefox 4.0b4
All
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Created attachment 459457 [details] [diff] [review]
v1

Now that the main window buttons aren't round any more, those in the Places library shouldn't be either.
Attachment #459457 - Flags: review?(dao)
Comment on attachment 459457 [details] [diff] [review]
v1

> #back-button > .toolbarbutton-icon {
>+  -moz-margin-start: 3px !important;
>   -moz-margin-end: 2px !important;
> }
> 
> #forward-button > .toolbarbutton-icon {
>   -moz-margin-start: 2px !important;
>+  -moz-margin-end: 3px !important;
> }

Please explain?
(Assignee)

Comment 2

7 years ago
Further up, a horizontal margin of 4px is set on the toolbarbutton-icons, so this just decreases the outer margins by 1px. Now their width matches the width of the small back/forward button pair in the main browser window. (Almost, at least - the forward button in the main browser window is 1px shorter.)
Comment on attachment 459457 [details] [diff] [review]
v1

> #placesToolbar > toolbarbutton {
>   list-style-image: url("chrome://browser/skin/places/toolbar.png");
>-  margin: 4px 6px 5px;
>-  padding: 1px 5px;
>+  margin: 4px 4px 5px;
>+  padding: 1px 3px;
>   -moz-border-radius: 100%;

remove this line
Attachment #459457 - Flags: review?(dao) → review+
(Assignee)

Comment 4

7 years ago
Created attachment 461643 [details] [diff] [review]
v2
Attachment #459457 - Attachment is obsolete: true
Attachment #461643 - Flags: approval2.0?
Attachment #461643 - Flags: approval2.0? → approval2.0+
(Assignee)

Comment 5

7 years ago
http://hg.mozilla.org/mozilla-central/rev/8522bc32ad34
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b4
You need to log in before you can comment on or make changes to this bug.