581064 - Find in page bar "find next" and "find previous" buttons are in the wrong order

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: General, defect)

Description

[Martijn Wargers (dead)]

The "find previous" button is before the "find next" button, which I find strange.
In Firefox, the "find next" button is first.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

hu? I'm not sure to understand what you mean?

The "find previous" is before the "find next" which makes sense and this is the same in Firefox no?

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #1)
> hu? I'm not sure to understand what you mean?
> 
> The "find previous" is before the "find next" which makes sense and this is the
> same in Firefox no?

My bad, it was looking weird to me but that's because I use a GTK Linux box and the order on GTK is [previous | next] which seems perfectly logical to me :)

So, the orders depends on your graphics toolkit.
http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/findbar.xml#218

I think we should do what is the correct order on maemo/android.

Comment 3

[Matt Brubeck (:mbrubeck)]

The Android browser's "Find in page" command has [<][>] (prev, next).

Comment 4

[Alex Faaborg [:faaborg] (Firefox UX)]

Especially when visually grouped (like on OS X) this is a valid natural mapping bug.  It's less of an issue on Windows where the controls are separate and have arrows (I believe Linux is similar).

Comment 5

[Matt Brubeck (:mbrubeck)]

Alex, this bug was asking us to change Fennec (currently [prev][next]) to match Firefox on Mac/Windows (currently [next][prev]).

I think you mean that Firefox on Mac/Windows has a mapping bug, in which case you want bug 416849 (and maybe a separate bug for Firefox on Windows).

Comment 6

[Alex Faaborg [:faaborg] (Firefox UX)]

Sorry about that, got thrown off by the "platform: all"