REFTEST TEST-UNEXPECTED-FAIL | file:///c:/talos-slave/mozilla-central-win7-opt-u-reftest-d2d/build/reftest/tests/layout/reftests/svg/dynamic-small-object-scaled-up-02.svg |

RESOLVED FIXED

Status

()

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: jrmuizel, Assigned: bas.schouten)

Tracking

(Blocks: 1 bug)

Trunk
x86
Windows Vista
Points:
---

Firefox Tracking Flags

(blocking2.0 betaN+)

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
This one has a pretty substantial difference.
(Assignee)

Updated

8 years ago
Assignee: nobody → bas.schouten
Status: NEW → ASSIGNED
OS: Mac OS X → Windows Vista
(Assignee)

Comment 1

8 years ago
Created attachment 460186 [details] [diff] [review]
Fix transformed stroke drawing

The problem here is that we're inverse transforming the stroke in order to set the transform on the rasterizer. This is needed because the miter angles and stroke width and such are untransformed. Because this path was really small when inverse transformed back to its original, the cairo fixed point precision of 8 fractional bits was insufficient to store the stroke properly and rounding errors occurred. I know inverse the transformation in D2D which uses floating point, avoiding the issue. This fixes the reftest.
Attachment #460186 - Flags: review?(jmuizelaar)
(Reporter)

Comment 2

8 years ago
Comment on attachment 460186 [details] [diff] [review]
Fix transformed stroke drawing

Why do the box tests go away?
(Assignee)

Comment 3

8 years ago
(In reply to comment #2)
> Comment on attachment 460186 [details] [diff] [review]
> Fix transformed stroke drawing
> 
> Why do the box tests go away?

Because I'm drawing a transformed geometry anyway. I could transform a rectangle geometry but I doubt it would perform that much fast, I could bring it back though.
(Reporter)

Comment 4

8 years ago
Comment on attachment 460186 [details] [diff] [review]
Fix transformed stroke drawing

Make sure you get rid of the DEBUG_LEVEL changes.
Attachment #460186 - Flags: review?(jmuizelaar) → review+
(Assignee)

Comment 5

8 years ago
This needs blocking to land.
blocking2.0: --- → ?
Blocks a blocker, let's go.
blocking2.0: ? → betaN+
(Assignee)

Comment 7

8 years ago
Pushed http://hg.mozilla.org/mozilla-central/rev/d29e7fff79b6.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Reporter)

Comment 8

8 years ago
This or the gradient patch seems to have caused a bunch of new reftest failures. Bas, can you try to figure out which and why?
(Assignee)

Comment 9

8 years ago
I believe these are intermittent failures sadly, I'm not sure why, when I tested locally I looked very briefly at a few, but they weren't really rendering problems. It was like two textboxes showing completely different text and such things. But I didn't look at what seemed to cause it yet.
You need to log in before you can comment on or make changes to this bug.