58109 - ABook: import can't handle Japanese address book filename correctly.

Status: VERIFIED FIXED

(MailNews Core :: Internationalization, defect, P3)

Description

[ji]

****observed with win32 2000102609 branch build****

When importing a text/ldif/csv/tab address book file, if the filename is in Japanese, the Ja filename is displayed
garbled both on import wizard during the importing and  main window after improting.

Steps to reproduce:
1. Export address book from 4.x and save it into a file with Japanese filename.
2. Launch Netscape 6 and bring up address book.
3. From address book, select File | Importing... 
   or from browser select Tasks | Tools | Import Utility
4. Select the file that you prepared at step 1 and import this file 
5. At the last screen of improt wizard, the Ja filename is garbled.
   And on address book list of main window, the Ja filename is garbled as well.

Will attach screenshots later.

Comment 1

[ji]

Attachment: Ja filename garbled on the last screen of import wizard.

Comment 2

[ji]

Attachment: Ja filename garbled on the address book main window.

Comment 3

[ji]

Attachment: An address book text file with a Japanese filename.

Comment 4

[nhottanscp]

Reassign to chuang.

Comment 5

[ji]

Although the Ja address book filename appears garbled after importing, the 
non-ASCII cards in it are displayed okay after importing.

Comment 6

[Katsuhiko Momoi]

ji, can you check to see if the same problem occurs when
you export a JPN named files from NS6 and then attempt 
to import it back?

Comment 7

[Katsuhiko Momoi]

Question 2:

Did we check the migration case where original 4.x 
ADBook files have Japanese names? Does that work OK?

Comment 8

[ji]

There is no export function on Netscape 6 yet.
For ja ABook name migrated from 4.x, it works ok except it needs to restart the
browser to be able to show up.
For the default personal address book name which is translated into Japanese on
Japanese 4.x release, after migration, the original Japanese name is not kept.
English "Personal Address Book" is used.
I'll file a seperate bug for it.

Comment 9

[ji]

Japanese Netscape 6 can migrate the default Ja personal address book name
correctly. So I won't file any additional bug related to this.

Comment 10

[Makoto Kato [:m_kato]]

Attachment: fix codes

Comment 11

[Makoto Kato [:m_kato]]

My fixess is 2 point.
o fix memory leak.  (change char* -> nsXPIDLCString)
o misstake charset convertion (AssignWithConversion -> SystemStringToUnicode)

chuang, if you have no enough time, please assign to me.

Comment 12

[scottputterman]

reassigning to [e-mail]

It would be a big help if you could get this in.

Comment 13

[Makoto Kato [:m_kato]]

can anyone review?

Comment 14

[nhottanscp]

r=nhotta

Comment 15

[David :Bienvenu]

sr=bienvenu (though do you really need to cast to a (const char *)? Won't the
compiler figure it out?

Comment 16

[Scott MacGregor]

sr=mscott

Comment 17

[Katsuhiko Momoi]

Mass change of QA contact to ji for the bugs filed by her.

Comment 18

[Makoto Kato [:m_kato]]

check in

Comment 19

[ji]

Verified with 02/19 linux and win32 mtrunk build.