581125 - cfx should display information on binary and/or profile locations when running

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Atul Varma [:atul]]

Particularly when cfx auto-detects the location of the user's Firefox/XULRunner binary, it can be hard to figure out which one it's actually found. This has surfaced a number of times when trying to help out SDK users on IRC and in the Jetpack google group.

As such, it'd be helpful if cfx displayed information like this when running an app:

  Using binary at '/Applications/Firefox.app/Contents/MacOS/firefox-bin'.
  Using profile at '/var/folders/vF/vFBh+uSBH3aPUHOJgagEuU+++TI/-Tmp-/tmpWHtmBk.mozrunner'.

Comment 1

[Atul Varma [:atul]]

Attachment: patch

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 459521 [details] [diff] [review]
patch

Looks good, works well, r=myk.  I would just suggesting compacting the output on one line to minimize scrolling, so instead of:

  Using binary at '/home/myk/bin/firefox'.
  Using profile at '/tmp/tmpKZTah9.mozrunner'.

It displays:

  using binary: /home/myk/bin/firefox; profile: /tmp/tmpKZTah9.mozrunner

(The quotation marks also seem unnecessary, as file paths are relatively easy to visually distinguish from prose.)

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Also, a=myk for checkin during freeze, as this is a small, contained, low-risk fix.

Comment 4

[Atul Varma [:atul]]

Thanks! Pushed:

Bug 581125 - cfx should display information on binary and/or profile locations when running
Atul Varma [:atul]
http://hg.mozilla.org/labs/jetpack-sdk/rev/6bb22412b16b

I didn't actually change the formatting of the two lines, just because I thought it was easier to see what one was by looking at the end of either line, but you're welcome to change it in the repo if you like, or we can change it later if lots of folks don't like it.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".