HAVE_MOVEMAIL should not be set in configure

VERIFIED FIXED

Status

MailNews Core
Profile Migration
P3
normal
VERIFIED FIXED
18 years ago
10 years ago

People

(Reporter: cls, Assigned: (not reading, please use seth@sspitzer.org instead))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

18 years ago
Filing on Shaver's behalf.  I'll let him fill in the details as I'm not sure I
understand the problem fully.
adding mike to the cc list.  he was just fixing something related for OS/2

see #58097

shaver, what's the scoop?
The scoop is (sorry for the delay) that we shouldn't have any compile-time
directive like HAVE_MOVEMAIL at all.  You shouldn't have to recompile to add or
remove movemail support.  Aren't mail protocols supposed to be pluggable?
(Reporter)

Comment 3

17 years ago
Ok, so can someone explain to me why we have HAVE_MOVEMAIL set in configure.in
but also in profile/pref-migrator/src/nsPrefMigration.cpp ?  That appears to be
the only use of HAVE_MOVEMAIL outside of the mailnews module.  If that's the
case and HAVE_MOVEMAIL is going to be defined there anyways, can we remove the
setting from  configure.in and define it in some local mailnews header?

(Reporter)

Comment 4

17 years ago
Created attachment 50307 [details] [diff] [review]
Make -DHAVE_MOVEMAIL localized to mailnews

Comment 5

17 years ago
Comment on attachment 50307 [details] [diff] [review]
Make -DHAVE_MOVEMAIL localized to mailnews

r=jag
Attachment #50307 - Flags: review+
(Reporter)

Comment 6

17 years ago
Patch checked in.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 7

17 years ago
verified all code fixes
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.