Closed Bug 581179 Opened 14 years ago Closed 14 years ago

TM: array grow/shrink code is ugh

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Version:
Other Branch
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: gal, Assigned: paul.biggar)

References

Details

We have ensure and resizeDenseArray. Both can shrink or grow, and are complex beyond all imagination. We should have

allocateDenseArrayElements
growDenseArrayElements
shrinkDenseArrayElements

grow should always backfill, allocate never (the caller will paste in stuff as needed in all call sites I believe)
Assignee: general → paul.biggar
Depends on: 580846
I think this bug is no longer valid, from looking the diff of bug 584917. We were switched to this interface, then we switched back. Now it maps straight onto slots, and there is no array-specific code here. I think there's nothing left to do here.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.