Closed
Bug 581180
Opened 15 years ago
Closed 6 years ago
array functions no longer have to do gymnastics to count holes
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
INVALID
People
(Reporter: gal, Unassigned)
References
Details
Our array functions used manual copy loops and a fair amount of complexity to maintain the hole count. Since we ripped out the counter, we can switch to simpler memcpy and fill loops.
Reporter | ||
Updated•15 years ago
|
Assignee: general → paul.biggar
Reporter | ||
Comment 1•15 years ago
|
||
We also have at least 4 ways to initialize array data (InitArrayElements, InitArrayObject, ...). We should reduce that to say ... 1?
![]() |
||
Comment 2•15 years ago
|
||
I just saw this in array_splice.
Comment 3•15 years ago
|
||
This is nasty code with nasty edge cases, but it would look much nicer once we have Lua-style arrays, so waiting til after that.
Assignee: pbiggar → general
Depends on: 586842
Updated•14 years ago
|
Summary: TM: array functions no longer have to do gymnastics to count holes → array functions no longer have to do gymnastics to count holes
![]() |
||
Comment 4•12 years ago
|
||
Bug 827490 just landed, which might allow this to happen now.
Assignee | ||
Updated•11 years ago
|
Assignee: general → nobody
Comment 5•6 years ago
|
||
Unlikely to be still valid, therefore closing as Invalid.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•