Closed Bug 581180 Opened 11 years ago Closed 2 years ago

array functions no longer have to do gymnastics to count holes

Categories

(Core :: JavaScript Engine, defect)

Other Branch
x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED INVALID

People

(Reporter: gal, Unassigned)

References

(Depends on 1 open bug)

Details

Our array functions used manual copy loops and a fair amount of complexity to maintain the hole count. Since we ripped out the counter, we can switch to simpler memcpy and fill loops.
Assignee: general → paul.biggar
We also have at least 4 ways to initialize array data (InitArrayElements, InitArrayObject, ...). We should reduce that to say ... 1?
I just saw this in array_splice.
This is nasty code with nasty edge cases, but it would look much nicer once we have Lua-style arrays, so waiting til after that.
Assignee: pbiggar → general
Depends on: 586842
Summary: TM: array functions no longer have to do gymnastics to count holes → array functions no longer have to do gymnastics to count holes
Bug 827490 just landed, which might allow this to happen now.
Assignee: general → nobody

Unlikely to be still valid, therefore closing as Invalid.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.