Closed Bug 581188 Opened 10 years ago Closed 10 years ago

test-page-worker test failures on trunk nightlies

Categories

(Add-on SDK Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: myk, Unassigned)

Details

I'm seeing three test-page-worker test failures on trunk nightly builds of Firefox on Windows, Mac, and Linux:

--------------------------------------------------------------------------------
error: TEST FAILED: test-page-worker.testContentAndAllowGettersAndSetters (failure)
error: fail: Correct type expected for scrollTo - function ("number" != "function")
info: Traceback (most recent call last):
  File "resource://testpkgs-jetpack-core-lib/page-worker.js", line 256, in onReadyListener
    errors.catchAndLog(callback).call(self);
  File "resource://testpkgs-jetpack-core-lib/errors.js", line 49, in anonymous
    return callback.apply(this, arguments);
  File "resource://testpkgs-jetpack-core-tests/test-page-worker.js", line 159, in step1
    "Correct type expected for scrollTo - function");
  File "resource://testpkgs-jetpack-core-lib/unit-test.js", line 229, in assertEqual
    this.fail(message);
  File "resource://testpkgs-jetpack-core-lib/unit-test.js", line 147, in fail
    console.trace();
...error: fail: Correct type expected for scrollTo - function again ("number" != "function")
info: Traceback (most recent call last):
  File "resource://testpkgs-jetpack-core-lib/page-worker.js", line 256, in onReadyListener
    errors.catchAndLog(callback).call(self);
  File "resource://testpkgs-jetpack-core-lib/errors.js", line 49, in anonymous
    return callback.apply(this, arguments);
  File "resource://testpkgs-jetpack-core-tests/test-page-worker.js", line 179, in step3
    "Correct type expected for scrollTo - function again");
  File "resource://testpkgs-jetpack-core-lib/unit-test.js", line 229, in assertEqual
    this.fail(message);
  File "resource://testpkgs-jetpack-core-lib/unit-test.js", line 147, in fail
    console.trace();
...........error: fail: Script isn't allowed to run by default.
info: Traceback (most recent call last):
  File "resource://testpkgs-jetpack-core-lib/page-worker.js", line 256, in onReadyListener
    errors.catchAndLog(callback).call(self);
  File "resource://testpkgs-jetpack-core-lib/errors.js", line 49, in anonymous
    return callback.apply(this, arguments);
  File "resource://testpkgs-jetpack-core-tests/test-page-worker.js", line 272, in check
    test.assert(foo != 3, "Script isn't allowed to run by default.");
  File "resource://testpkgs-jetpack-core-lib/unit-test.js", line 198, in assert
    this.fail(message);
  File "resource://testpkgs-jetpack-core-lib/unit-test.js", line 147, in fail
    console.trace();
--------------------------------------------------------------------------------

The first two failures are in testContentAndAllowGettersAndSetters.  The third one is in testDisallowScript.  But they all test |allow.script: false|, so they seem to be the same failure.

Branch release builds don't exhibit the problem.
Felipe: do you have an idea what might be happening here?
It seems that the docShell.allowJavascript property stopped working on nightlies. I ran the following test case on 3.6 and trunk:

- Open JS Shell from the extension developer extension, set context to browser.xul

- Run the following, line by line:

  var ifr = window.document.createElementNS("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul", "iframe");
  ifr.setAttribute("type", "content");
  window.document.documentElement.appendChild(ifr);
  ifr.docShell.allowJavascript = false;
  ifr.setAttribute("src", "data:text/html,<script>alert(1)</script>");

On 3.6 the alert doesn't run, on trunk it does.
This seems fixed on today's nightly. Can you confirm, Myk?

Should I mark as WORKSFORME or track down the bug where this was fixed?
Yup, it works for me on today's nightly, too.  What good luck!  No need to track down the bug that fixed it, I don't think.  I've marked as worksforme.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".
Component: Jetpack SDK → General
Product: Mozilla Labs → Add-on SDK
QA Contact: jetpack-sdk → general
You need to log in before you can comment on or make changes to this bug.