581190 - new_since on Bug.comments call broken with respect to timezones

Status: RESOLVED WONTFIX

(Webtools Graveyard :: BzAPI, defect)

Description

[Gervase Markham [:gerv]]

The new_since parameter on the XML-RPC call for comments is broken with respect to timezones.

In Bugzilla::WebService::Bug->comments(), it gets turned into an "after" parameter to Bug->comments():
        my $comments = $bug->comments({ order => 'oldest_to_newest',
                                        after => $params->{new_since} });

In Bugzilla::Bug::comments(), that parameter gets interpreted by Bugzilla::Util::datetime_from():
        my $from = datetime_from($params->{after});

datetime_from() uses the Bugzilla local timezone, rather than UTC, if no timezone is given.
        # If a timezone was specified, use it. Otherwise, use the
        # local timezone.
        time_zone => Bugzilla->local_timezone->offset_as_string($time[6]) 
                     || Bugzilla->local_timezone,

So new_since is interpreted in the local timezone rather than UTC.

As of 3.6, I believe the intention is that the API send and receive all times in UTC.

Gerv

Comment 1

[Max Kanat-Alexander]

Actually, I don't see a bug there. new_since will be properly converted to a date in the local timezone by Bugzilla::WebService::Server, as long as it is sent as a dateTime.iso8601 field and not a string. I suspect you are sending it as a string?

Comment 2

[Gervase Markham [:gerv]]

Ah. <sigh> Yes, I am. Back to filing that bug on BZ::Client... 

Gerv

Comment 3

[Gervase Markham [:gerv]]

BzAPI is very much in maintenance mode and is being superseded by the BzAPI shim on top of the native Bugzilla REST API, and that native API itself. So this bug is not going to be fixed.

Gerv