Closed Bug 581267 Opened 12 years ago Closed 12 years ago

Merge Page and UIClass

Categories

(Firefox Graveyard :: Panorama, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: raymondlee, Assigned: raymondlee)

References

Details

No description provided.
Assignee: nobody → raymond
http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/259543691391

Is it necessary to have a Tabbar object?  Can we just merge it into the UIManager as well?
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Raymond, looks great! 

Yes, please roll Tabbar into UIManager as well.
Blocks: 581612
Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".
Product: Mozilla Labs → Firefox
Target Milestone: -- → ---
Version: unspecified → Trunk
Raymond, rev 50189 for this patch introduces two JS warnings, in case you want to fix them. In UI:_createGroupItemOnDrag():finalize(){} the variable box is missing a 'let', and in the for-each-in loop below that, tab is missing a 'let'.
(In reply to comment #4)
> Raymond, rev 50189 for this patch introduces two JS warnings, in case you want
> to fix them. In UI:_createGroupItemOnDrag():finalize(){} the variable box is
> missing a 'let', and in the for-each-in loop below that, tab is missing a
> 'let'.

Thanks Sean.  That has been fixed!
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.