Closed
Bug 581286
Opened 14 years ago
Closed 14 years ago
Don't duplicate tabbox.advanceSelectedTab and key handling code
Categories
(Firefox Graveyard :: Panorama, defect)
Firefox Graveyard
Panorama
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Mardak, Assigned: Mardak)
References
Details
Attachments
(1 file)
|
11.79 KB,
patch
|
iangilman
:
feedback+
|
Details | Diff | Splinter Review |
Bug 565968 has a some code from tabbox to handle switching tabs. We shouldn't duplicate the code and just reuse it.
|
Assignee | |
Comment 1•14 years ago
|
||
http://hg.mozilla.org/users/edward.lee_engineering.uiuc.edu/tabcandy-central/rev/15284adb0a68 Prevent tabs from showing up in the tabbar by hiding them instead of collapsing so that existing tabbox code knows to skip over them. Remove key handling code except for activating tabcandy and switching groups.
Assignee: nobody → edilee
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 2•14 years ago
|
||
Switched from collapsed to hidden.
Attachment #459734 -
Flags: feedback?(ian)
|
||
Comment 3•14 years ago
|
||
Comment on attachment 459734 [details] [diff] [review] v1 Looks good.
Attachment #459734 -
Flags: feedback?(ian) → feedback+
|
||
Comment 4•14 years ago
|
||
Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy. Filter the bugmail spam with "tabcandymassmove".
Product: Mozilla Labs → Firefox
Target Milestone: -- → ---
|
||
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•