581331 - BrowserUI.goToURI should always apply third-party fixup to URI

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Bug 575581 made sure we were applying LOAD_FLAGS_ALLOW_THIRD_PARTY_FIXUP correctly to incoming URIs, so keyword searching worked better. However, if the incoming URI required a new tab to be created, we skipped the LOAD_FLAGS_ALLOW_THIRD_PARTY_FIXUP code path.

The result is "Server not found" errors if you type "cnn.com" from the startup page.

This patch works like the BrowserUI.doButtonSearch code, and will always apply the third-party fixup to the incoming URI.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 459790 [details] [diff] [review]
patch

>diff --git a/chrome/content/browser-ui.js b/chrome/content/browser-ui.js
>--- a/chrome/content/browser-ui.js
>+++ b/chrome/content/browser-ui.js
>@@ -490,22 +490,23 @@ var BrowserUI = {
>     this._edit.value = aURI;
> 
>     // We need to keep about: pages opening in new "local" tabs. We also want to spawn
>     // new "remote" tabs if opening web pages from a "local" about: page.
>     let currentURI = getBrowser().currentURI;
>     let useLocal = Util.isLocalScheme(aURI);
>     let hasLocal = Util.isLocalScheme(currentURI.spec);
>     if (hasLocal != useLocal) {
>-      Browser.addTab(aURI, true);
>-    } else {
>-      let loadFlags = Ci.nsIWebNavigation.LOAD_FLAGS_ALLOW_THIRD_PARTY_FIXUP;
>-      getBrowser().loadURIWithFlags(aURI, loadFlags, null, null);
>+      let tab = Browser.addTab("about:blank", true);
>+      tab.browser.stop();
>     }
> 
>+    let loadFlags = Ci.nsIWebNavigation.LOAD_FLAGS_ALLOW_THIRD_PARTY_FIXUP;
>+    getBrowser().loadURIWithFlags(aURI, loadFlags, null, null);
>+
>     // Delay doing the fixup so the raw URI is passed to loadURIWithFlags
>     // and the proper third-party fixup can be done
>     let fixupFlags = Ci.nsIURIFixup.FIXUP_FLAG_ALLOW_KEYWORD_LOOKUP;
>     let uri = gURIFixup.createFixupURI(aURI, fixupFlags);
>     gHistSvc.markPageAsTyped(uri);
>   },
> 
>   showAutoComplete: function showAutoComplete() {

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/d28d52c4b8cf

Comment 4

[Aakash Desai [:aakashd]]

verified FIXED on build:

Mozilla/5.0 (Android; U; Linux armv71; en-US; rv:2.0b2pre) Gecko/20100726 Namoroka/4.0b2pre Fennec/2.0a1pre

Comment 5

[Dão Gottwald [:dao]]

bugspam