Newsletter signup - add country to First Run

VERIFIED FIXED

Status

www.mozilla.org
General
VERIFIED FIXED
8 years ago
6 years ago

People

(Reporter: Eve Murto, Assigned: sgarrity)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

8 years ago
Please add a field under the email address for "Country" and a picklist of the countries.   (Please have it selected as default on "United States" option. ) 

See the country picklist here as an example (student reps program signup): 

http://mozilla.us1.list-manage.com/subscribe?u=168bf22f976f5a68fe5770d19&id=9e35bff4f4

Thank you,  Eve  x288
Steven,
Since you're working on the newsletter landing page (Bug #576413) which also requires adding a new field for "Country" in Basket database, can you pick this up?
Assignee: nobody → steven
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Comment 2

8 years ago
This has been added in trunk in r72263. If it looks ok, we should get QA to take a look.
(Assignee)

Updated

8 years ago
Depends on: 585743
(In reply to comment #2)
> This has been added in trunk in r72263. If it looks ok, we should get QA to
> take a look.

It looks OK to me, but I didn't painstakingly double-check against the complete list from the URL in comment 0.
(Reporter)

Comment 4

8 years ago
Gently checking in : has this been completed now? 
Eve
(Assignee)

Comment 5

8 years ago
The form is done on the firstrun page, but it was waiting on Bug 585743. Alex - is that live?
(Reporter)

Comment 6

8 years ago
What is the next step needed to complete this?
(In reply to comment #6)
> What is the next step needed to complete this?

I need to make a change to the Basket submitter.  Doing that now, and then I'll work with Steven on pushing this today.
r72849 on trunk, updates the submit handler to include the country field
(Assignee)

Comment 9

8 years ago
I'm working on merging this to stage with Alex now. r73348 merges some of the related files from trunk->stage. More to come.
(Assignee)

Comment 10

8 years ago
The rest of the changes for this have merged from trunk to stage in r73413.

Alex, can you push this to production?
Keywords: push-needed
(Reporter)

Comment 11

8 years ago
Please check that all countries in the world are on the drop down list as options (not limited to Mozilla locales).  This was just brought to my attention that the list is incomplete. It should be all countries. Thank you!
(In reply to comment #11)
> Please check that all countries in the world are on the drop down list as
> options (not limited to Mozilla locales).  This was just brought to my
> attention that the list is incomplete. It should be all countries. Thank you!

What's missing from http://pastebin.mozilla.org/789213?
(Reporter)

Comment 14

8 years ago
Looks great - is this pushed to production already?
(In reply to comment #14)
> Looks great - is this pushed to production already?

Not yet, but from my side, this can go live at any time, hence the push-needed keywords.
(Reporter)

Comment 16

8 years ago
Who takes the next step to get this into production? Thank you!  -Eve
(In reply to comment #16)
> Who takes the next step to get this into production? Thank you!  -Eve

Usually Alex or John?

Comment 18

8 years ago
Steven, is this still the relevant list of files to push?

http://viewvc.svn.mozilla.org/vc?revision=73413&view=revision
(Assignee)

Comment 19

8 years ago
(In reply to comment #18)
> Steven, is this still the relevant list of files to push?
> http://viewvc.svn.mozilla.org/vc?revision=73413&view=revision

Yup.
pushed
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Keywords: push-needed
Resolution: --- → FIXED
(Reporter)

Comment 22

8 years ago
Please have the default country say "Your Country" in light gray font,  rather than Afghanistan. (Worried about getting false positives for Afghanistan). 

Thank you. -Eve
Component: www.mozilla.org/firefox → www.mozilla.org
Product: Websites → Websites
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in before you can comment on or make changes to this bug.