Closed Bug 581561 Opened 9 years ago Closed 9 years ago

Tapping outside the contextmenu to dismiss it should not fire a click

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mfinkle, Assigned: vingtetun)

References

Details

Attachments

(1 file)

Tapping outside the contextmenu is a common way to dismiss the menu without making a selection.  In Fennec, this seems to fire a click on the element where the user taps.

We don't want this, imo
Blocks: 581252
OS: Linux → All
Hardware: x86 → All
Attached patch PatchSplinter Review
This patch add a container panel for the context popup with the effect of:
 * disabling the click outside the context-menu since it is done on the container not on the content (use of the .modal-block css class to show a dark transparent background over the UI, like a,n alert box)
 * allow to use pack: center and align: center to always have the context menu on the middle when the window is resize (it missed just the resizing part to have the context menu fully functionnal on this case)
Assignee: nobody → 21
Attachment #460213 - Flags: review?(mark.finkle)
Attachment #460213 - Flags: review?(mark.finkle) → review+
http://hg.mozilla.org/mobile-browser/rev/974c86b77f5f

I've checked to see if I can remove the code (the popupState checks) from InputHandler.js but we still need them for the moment
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b2pre) Gecko/2010727 Namoroka/4.0b2pre Fennec/2.0a1pre

and

Mozilla/5.0 (Android; U; Linux armv71; en-US; rv:2.0b2pre) Gecko/20100727 Namoroka/4.0b2pre Fennec/2.0a1pre
Status: RESOLVED → VERIFIED
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.