places-teardown should be double enqueued

RESOLVED FIXED in mozilla2.0b4

Status

()

Toolkit
Places
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: mak, Assigned: mak)

Tracking

Trunk
mozilla2.0b4
Points:
---

Firefox Tracking Flags

(blocking2.0 final+)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
we must ensure that any enqueued work done by places-shutdown observers is done before proceeding with teardown (will be an issue once we close the db connection there instead that in dbflush)
(Assignee)

Comment 1

7 years ago
Created attachment 460026 [details] [diff] [review]
patch v1.0

the structure of PlacesEvent with a separate Notify helper is due to the fact I plan to reuse it with other stuff (in temp tables removal for example), so I can reuse it to fire a notification on AsyncClose.
Attachment #460026 - Flags: review?(sdwilsh)
(Assignee)

Comment 2

7 years ago
asking blocking for proper ordering of shutdown events.
blocking2.0: --- → ?
blocking2.0: ? → final+
Comment on attachment 460026 [details] [diff] [review]
patch v1.0

>+class PlacesEvent : public nsIRunnable
Still should be inheriting from nsRunnable here.

>+  NS_IMETHODIMP Run() { return Notify(); }
Follow style please

>+  nsresult
>+  Notify()
this doesn't need to return anything, and I think our style is return type on same line for methods inside a class

r=sdwilsh with those changes.
Attachment #460026 - Flags: review?(sdwilsh) → review+

Updated

7 years ago
Whiteboard: [needs new patch]
(Assignee)

Comment 4

7 years ago
Created attachment 462384 [details] [diff] [review]
patch v1.1

addresses comments
Attachment #460026 - Attachment is obsolete: true
(Assignee)

Updated

7 years ago
Whiteboard: [needs new patch]
(Assignee)

Comment 5

7 years ago
forgot to close bug
http://hg.mozilla.org/mozilla-central/rev/49ac32a3c332
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b4
You need to log in before you can comment on or make changes to this bug.