Closed Bug 581660 Opened 12 years ago Closed 12 years ago

places-teardown should be double enqueued

Categories

(Toolkit :: Places, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla2.0b4
Tracking Status
blocking2.0 --- final+

People

(Reporter: mak, Assigned: mak)

Details

Attachments

(1 file, 1 obsolete file)

we must ensure that any enqueued work done by places-shutdown observers is done before proceeding with teardown (will be an issue once we close the db connection there instead that in dbflush)
Attached patch patch v1.0 (obsolete) — Splinter Review
the structure of PlacesEvent with a separate Notify helper is due to the fact I plan to reuse it with other stuff (in temp tables removal for example), so I can reuse it to fire a notification on AsyncClose.
Attachment #460026 - Flags: review?(sdwilsh)
asking blocking for proper ordering of shutdown events.
blocking2.0: --- → ?
blocking2.0: ? → final+
Comment on attachment 460026 [details] [diff] [review]
patch v1.0

>+class PlacesEvent : public nsIRunnable
Still should be inheriting from nsRunnable here.

>+  NS_IMETHODIMP Run() { return Notify(); }
Follow style please

>+  nsresult
>+  Notify()
this doesn't need to return anything, and I think our style is return type on same line for methods inside a class

r=sdwilsh with those changes.
Attachment #460026 - Flags: review?(sdwilsh) → review+
Whiteboard: [needs new patch]
Attached patch patch v1.1Splinter Review
addresses comments
Attachment #460026 - Attachment is obsolete: true
Whiteboard: [needs new patch]
forgot to close bug
http://hg.mozilla.org/mozilla-central/rev/49ac32a3c332
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b4
You need to log in before you can comment on or make changes to this bug.