581690 - Restore the ability to move several bugs at once to another installation

Status: RESOLVED FIXED

(Bugzilla :: Bug Import/Export & Moving, defect)

Description

[Frédéric Buclin]

Moving several bugs at once has been removed, as mentioned in bug 556422 comment 2. If importxml.pl cannot handle this correctly, it should be fixed. But removing this feature is a weird way to fix the problem.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

One XML bugmail is generated per bug, so importxml.pl can still import them on a per-bug basis.

Comment 2

[Frédéric Buclin]

Attachment: patch, v1.1

Move the "Move Bugs to ..." button below the Groups table when editing several bugs at once.

Comment 3

[Max Kanat-Alexander]

Comment on attachment 461944 [details] [diff] [review]
patch, v1.1

There was some reason that I did oldbugmove_$id. I don't remember what it was, but I'm sure it was a good reason. I think perhaps what we should do is to have an additional thing called oldbugmove_multiple or oldbugmove_all, and _bug_is_moving should always return true if it's set.

Comment 4

[Frédéric Buclin]

Comment on attachment 461944 [details] [diff] [review]
patch, v1.1

I thought about that too, but I couldn't find a good reason to append the bug ID at the end. Else you could pass oldbugmove_multiple all the time, even for single bugs, which has the same effect as naming it oldbugmove directly, which is why I removed the bug ID. So unless you can remember what the reason was *exactly*, please don't deny review.

Comment 5

[Max Kanat-Alexander]

I'm pretty certain that it involved working around an important bug that I hit during development. I just don't recall what the bug was.

Comment 6

[Frédéric Buclin]

Well, if someone can give me STR for this forgotten important bug, I would be happy to fix the problem in a subsequent bug. Maybe that was a problem at some point while moving the feature to an extension, and the problem disappeared in your final patch.

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified extensions/OldBugMove/Extension.pm
added extensions/OldBugMove/template/en/default/hook/list
modified extensions/OldBugMove/template/en/default/hook/bug/edit-after_comment_textarea.html.tmpl
added extensions/OldBugMove/template/en/default/hook/list/edit-multiple-after_groups.html.tmpl
modified template/en/default/list/edit-multiple.html.tmpl
Committed revision 7439.


Committing to: bzr+ssh://[e-mail]/bugzilla/4.0/
modified extensions/OldBugMove/Extension.pm
added extensions/OldBugMove/template/en/default/hook/list
modified extensions/OldBugMove/template/en/default/hook/bug/edit-after_comment_textarea.html.tmpl
added extensions/OldBugMove/template/en/default/hook/list/edit-multiple-after_groups.html.tmpl
modified template/en/default/list/edit-multiple.html.tmpl
Committed revision 7380.

Comment 7

[Max Kanat-Alexander]

Comment on attachment 461944 [details] [diff] [review]
patch, v1.1

At the very least, it's dangerous--any time set_all is called on a bug on any page where the "oldbugmove" item was submitted, every single bug that set_all is called on will have its status and resolution changed, whether the caller intended that or not. That's a recipe for future trouble, even if there isn't trouble now.

Comment 8

[Frédéric Buclin]

We never had a button whose ID depends on the bug ID. There is no reason for the "Move To ..." button to be an exception. It's like saying you pass "RESOLVED FIXED", and then complain that every bug in set_all() will be set to this status and resolution. That's simply how things work.

Comment 9

[Max Kanat-Alexander]

(In reply to comment #8)
> We never had a button whose ID depends on the bug ID.

  Well, I understand what you're saying, but that's not a logical response to my argument, really. I'll explain why:

> It's like saying you pass
> "RESOLVED FIXED", and then complain that every bug in set_all() will be set to
> this status and resolution.

  No, it's not. For example, let's say I want to write an extension to modify certain field values on bug B when updating bug A. In modern Bugzilla, the correct way to do this is to use set_all. So, I move Bug A, and I didn't intend to move Bug B, but it also gets moved, simply because I *called* set_all. I didn't have to pass any bug_status argument to set_all--I just had to *call* it.

Comment 10

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/qa/4.4/
modified t/test_bug_edit.t
Committed revision 238.

Committing to: bzr+ssh://[e-mail]/bugzilla/qa/4.2/
modified t/test_bug_edit.t
Committed revision 228.