58179 - End date not included in queries

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect, P2)

Description

[Curt Patrick (gone)]

When querying for bugs across a range of dates the last date is not included in 
the results.  This is probably not what the user would expect.

Comment 1

[Curt Patrick (gone)]

Attachment: Patch which fixes this bug.

Comment 2

[Dave Miller [:justdave]]

Won't this patch break it if the user specifies a specific time instead of just a 
date?

Comment 3

[Matthew Tuck [:CodeMachine]]

Hmm, yeah.  An unspecified time should convert to either 12:00am or 11:59pm
depending on what field it's in.

Comment 4

[Jacob Steenhagen]

-> New Bugzilla Product

Comment 5

[Jacob Steenhagen]

Wrong Component

Comment 6

[Gervase Markham [:gerv]]

Removing patch keyword; Dave found problems with it. We need a fixed version.

Gerv

Comment 7

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 8

[Matthew Tuck [:CodeMachine]]

*** Bug 145450 has been marked as a duplicate of this bug. ***

Comment 9

[Steve Lamm]

Attachment: Add option to SqlifyDate to add a day

This patch fixes the date range in the "Bug Changes" box. I have not looked at
the date ranges in the "Boolean Charts".

Comment 10

[Joel Peshkin]

These bugs appear to be abandoned.  Retargeting to 2.20

Comment 11

[Max Kanat-Alexander]

Hey Joel, have you fixed this already, or will your sqlifyDate cleanup fix this?

Comment 12

[Joel Peshkin]

No.  It is still <= 0000 on the day specificed rather than <= 2359 on the day
specified.  Steve's approach is probably a decent way to do it, but we should
check the cross-db stuff too.  We need to go through the code and makes sure
that all calls to sqlifydate know which way they are comparing and make it
consistent.

Comment 13

[Marc Schumann [:Wurblzap]]

Comment on attachment 128192 [details] [diff] [review]
Add option to SqlifyDate to add a day

Hit by bitrot...

Comment 14

[Frédéric Buclin]

Only security and dataloss fixes will be accepted on the 2.20 branch.

Comment 15

[RenegadeX]

(In reply to comment #14)
> Only security and dataloss fixes will be accepted on the 2.20 branch.

Is 'Zarro Boogs found.' on a search that should yield results not considered data loss? As mentioned in Bug 145450 (Dupe of this) entering an end date ('2006-11-24') completely breaks the search.

I recently did a Search for a Bug that I had read a user had filed on a specific date, but I did not know its #. Guesing a probable keyword and entering the date in both fields of the 'changed between', I netted 'Zarro Boogs found'. I tried again and again, wasting probably 10 minutes trying different keywords, date ranges and selected search items - all to no avail.

Yet I take out the end date from the search and there it is.

This is a simple problem wit what should be a very simple solution, yet the Bug is 6 YEARS and 1 month old now. That's shocking, and sad.

Comment 16

[Boris 'pi' Piwinger]

The bug is still around in Bugzilla.Mozilla.org as of today.

pi

Comment 17

[Max Kanat-Alexander]

  We should probably fix this, but if we do, the UI needs to be changed to say "through" instead of "to", if it says "to" anywhere.

Comment 21

[Frédéric Buclin]

Attachment: patch, v1

Comment 22

[David Lawrence [:dkl]]

Comment on attachment 611034 [details] [diff] [review]
patch, v1

Review of attachment 611034 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=dkl

Comment 23

[Frédéric Buclin]

11.5 years to fix this bug. :-/

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/Search.pm
Committed revision 8174.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.2/
modified Bugzilla/Search.pm
Committed revision 8063.